build(deps): update test JSONPath to 2.10.0#790
Conversation
0fc81b1 to
d6801e0
Compare
d6801e0 to
b9154dc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9154dc44e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
thanks for keeping this focused. i found one test-graph compatibility issue before approving: json-path 2.10.0 brings slf4j-api 2.0.17, while Spring Boot 2.7.18 uses Logback 1.2 and SLF4J 1.7. Gradle resolves the higher SLF4J version, so a test that starts SpringApplication or uses @SpringBootTest can get the NOP factory and fail logging initialization. could you exclude that transitive dependency or strictly constrain this test configuration to SLF4J 1.7.x? happy to recheck once that is in.
b9154dc to
e16d9df
Compare
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
looks good, thanks! the current head fixes the earlier slf4j compatibility issue with a strict 1.7.36 test constraint and a focused startup regression test.
e16d9df to
b375218
Compare
b375218 to
7369cf4
Compare
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
looks good, thanks for keeping this focused!
Summary
openai-java-coreandopenai-java-client-okhttp, and the Spring Boot starter test graphJSONPath 2.10.0 is the latest stable release on the Java 8-compatible 2.x line; JSONPath 3.0.0 requires Java 17. Both JSONPath 2.10.0 and its json-smart 2.6.0 dependency have Java 8 classfile level 52.
Alert #37's separate json-smart 2.5.1 path comes from Azure Identity in the example module, not JSONPath. It is outside this PR's scope and is already addressed by #779.
Downstream compatibility
This is limited to
testImplementationconstraints. Generated Maven POMs and Gradle module metadata for all three affected published modules contain neither JSONPath nor json-smart. There are no production source, bytecode, public API, runtime dependency, Java baseline, or release-version changes for SDK consumers.A japicmp comparison of JSONPath 2.7.0 and 2.10.0 found no public binary or source incompatibilities. The reported changes are additions and a visibility widening.
Validation
matchingJsonPathintegration passes under Jackson 2.14.0 and 2.18.9testJacksonPublished, and the published-Jackson WireMock check pass (external generated-API mock-server tests skipped locally)./scripts/build --no-configuration-cache./scripts/lint./scripts/detect-breaking-changes origin/main