Skip to content

build(deps): migrate test WireMock to Jetty 12#798

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/update-wiremock-jetty12
Jul 17, 2026
Merged

build(deps): migrate test WireMock to Jetty 12#798
jbeckwith-oai merged 1 commit into
mainfrom
codex/update-wiremock-jetty12

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • migrate the test-only mock server from wiremock-jre8 2.35.2 / Jetty 9.4 to wiremock-jetty12 3.13.2
  • align Jetty core and EE10 modules on 12.0.33, addressing Dependabot alerts #67 and #32
  • scope the Java 17 requirement to resolvable test classpaths; published SDK variants remain Java 8
  • run the normal test suites on the secure published Jackson 2.18.9 release while retaining a separate Jackson 2.14 compatibility pass for core and model behavior
  • update the Handlebars response-templating compatibility test for WireMock 3's built-in transformer

Why

WireMock 2 pins the end-of-life Jetty 9.4 line. There is no patched Jetty 9.4 release for the request-smuggling advisory, so clearing the remaining Jetty alerts requires moving the test server to WireMock's Jetty 12 integration. WireMock 3 also requires Java 17 and newer Jackson APIs, which previously conflicted with the repository's Java 8 publication target and Jackson 2.14 compatibility runtime.

Impact

This changes test and build configuration only. It does not change published dependencies or public APIs, and the produced SDK JARs still use Java 8 bytecode.

Validation

  • ./scripts/lint
  • ./scripts/build --no-daemon --console plain
  • ./scripts/test --no-daemon --console plain with the real local OpenAPI mock server
  • forced no-cache :openai-java-client-okhttp:test
  • WireMock-specific tests plus the complete testJacksonCompatibility pass
  • dependency insight confirms Jetty 12.0.33 across core, EE10, HTTP/2, and servlet modules
  • dependency insight confirms normal tests use Jackson 2.18.9 and compatibility tests use Jackson 2.14.0
  • verified the core JAR remains Java 8 bytecode (major version 52)

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review July 17, 2026 20:27
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner July 17, 2026 20:27
@openai-sdks

openai-sdks Bot commented Jul 17, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 14.426s for Java SDK PR #798.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 141ms
tests/chat-completions-create.test.ts ✅ Passed 436ms
tests/chat-completions-stream.test.ts ✅ Passed 266ms
tests/files-content-binary.test.ts ✅ Passed 209ms
tests/files-create-multipart.test.ts ✅ Passed 300ms
tests/files-list-pagination.test.ts ✅ Passed 218ms
tests/initialize-config.test.ts ✅ Passed 125ms
tests/instance-isolation.test.ts ✅ Passed 104ms
tests/models-list.test.ts ✅ Passed 242ms
tests/responses-background-lifecycle.test.ts ✅ Passed 252ms
tests/responses-body-method-errors.test.ts ✅ Passed 479ms
tests/responses-cancel-timeout.test.ts ✅ Passed 229ms
tests/responses-cancel.test.ts ✅ Passed 288ms
tests/responses-compact-retries.test.ts ✅ Passed 212ms
tests/responses-compact.test.ts ✅ Passed 242ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 402ms
tests/responses-create-advanced.test.ts ✅ Passed 1.049s
tests/responses-create-disconnect.test.ts ✅ Passed 1.065s
tests/responses-create-errors.test.ts ✅ Passed 334ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 393ms
tests/responses-create-retries.test.ts ✅ Passed 225ms
tests/responses-create-stream-failures.test.ts ✅ Passed 138ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 209ms
tests/responses-create-stream-wire.test.ts ✅ Passed 5.553s
tests/responses-create-stream.test.ts ✅ Passed 369ms
tests/responses-create-terminal-states.test.ts ✅ Passed 281ms
tests/responses-create-timeout.test.ts ✅ Passed 278ms
tests/responses-create.test.ts ✅ Passed 491ms
tests/responses-delete.test.ts ✅ Passed 222ms
tests/responses-input-items-errors.test.ts ✅ Passed 309ms
tests/responses-input-items-list.test.ts ✅ Passed 253ms
tests/responses-input-items-options.test.ts ✅ Passed 162ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 208ms
tests/responses-input-tokens-count.test.ts ✅ Passed 263ms
tests/responses-malformed-inputs.test.ts ✅ Passed 4.647s
tests/responses-not-found-errors.test.ts ✅ Passed 326ms
tests/responses-parse.test.ts ✅ Passed 403ms
tests/responses-retrieve-retries.test.ts ✅ Passed 244ms
tests/responses-retrieve.test.ts ✅ Passed 236ms
tests/responses-stored-method-errors.test.ts ✅ Passed 980ms
tests/retry-behavior.test.ts ✅ Passed 3.394s
tests/sdk-error-shape.test.ts ✅ Passed 413ms

View OkTest run #29611284647

SDK merge (d7ed3eb419ec) · head (670dadfa3b4b) · base (c3be8f9d60b2) · OkTest (fd7a761c81c1)

@HAYDEN-OAI HAYDEN-OAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for keeping the wiremock upgrade test-only and the java 8 publication target intact.

@jbeckwith-oai
jbeckwith-oai merged commit 0522672 into main Jul 17, 2026
15 checks passed
@stainless-app stainless-app Bot mentioned this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants