Skip to content

Align WireMock Jackson test classpaths#799

Open
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/align-wiremock-jackson-test-compile
Open

Align WireMock Jackson test classpaths#799
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/align-wiremock-jackson-test-compile

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • apply the existing secure Jackson 2.18.9 resolution rule to both testCompileClasspath and testRuntimeClasspath
  • keep WireMock 3.13.2 usable while preventing its Jackson 2.20.1 BOM from selecting versions covered by Dependabot alerts 59, 95, 97, 99, and 101
  • preserve published dependency metadata and the SDK's older-Jackson compatibility lane

Root cause

The OkHttp module already constrained Jackson on the test runtime classpath, but its test compile classpath still accepted WireMock's Jackson 2.20.1 BOM. GitHub therefore recorded vulnerable jackson-core and jackson-databind versions even though the runtime test graph was secure.

Impact

This changes only test dependency resolution. Generated Maven POM and Gradle module metadata remain free of WireMock and test-only Jackson dependencies.

Validation

  • :openai-java-client-okhttp:dependencyInsight for jackson on both test classpaths: all Jackson modules resolve to 2.18.9
  • :openai-java-client-okhttp:test --rerun-tasks
  • :openai-java-core:testJacksonCompatibility --rerun-tasks
  • generated Maven POM and Gradle module metadata inspection
  • ./scripts/lint
  • ./scripts/build --rerun-tasks
  • ./scripts/test --rerun-tasks with the repository OpenAPI mock server, including ProGuard and R8 checks

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review July 18, 2026 01:49
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner July 18, 2026 01:49
@openai-sdks

openai-sdks Bot commented Jul 18, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 14.215s for Java SDK PR #799.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 144ms
tests/chat-completions-create.test.ts ✅ Passed 634ms
tests/chat-completions-stream.test.ts ✅ Passed 307ms
tests/files-content-binary.test.ts ✅ Passed 262ms
tests/files-create-multipart.test.ts ✅ Passed 298ms
tests/files-list-pagination.test.ts ✅ Passed 239ms
tests/initialize-config.test.ts ✅ Passed 116ms
tests/instance-isolation.test.ts ✅ Passed 173ms
tests/models-list.test.ts ✅ Passed 274ms
tests/responses-background-lifecycle.test.ts ✅ Passed 226ms
tests/responses-body-method-errors.test.ts ✅ Passed 502ms
tests/responses-cancel-timeout.test.ts ✅ Passed 216ms
tests/responses-cancel.test.ts ✅ Passed 274ms
tests/responses-compact-retries.test.ts ✅ Passed 282ms
tests/responses-compact.test.ts ✅ Passed 231ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 480ms
tests/responses-create-advanced.test.ts ✅ Passed 1.048s
tests/responses-create-disconnect.test.ts ✅ Passed 1.103s
tests/responses-create-errors.test.ts ✅ Passed 340ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 259ms
tests/responses-create-retries.test.ts ✅ Passed 248ms
tests/responses-create-stream-failures.test.ts ✅ Passed 162ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 198ms
tests/responses-create-stream-wire.test.ts ✅ Passed 5.153s
tests/responses-create-stream.test.ts ✅ Passed 100ms
tests/responses-create-terminal-states.test.ts ✅ Passed 291ms
tests/responses-create-timeout.test.ts ✅ Passed 211ms
tests/responses-create.test.ts ✅ Passed 191ms
tests/responses-delete.test.ts ✅ Passed 196ms
tests/responses-input-items-errors.test.ts ✅ Passed 248ms
tests/responses-input-items-list.test.ts ✅ Passed 296ms
tests/responses-input-items-options.test.ts ✅ Passed 256ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 206ms
tests/responses-input-tokens-count.test.ts ✅ Passed 441ms
tests/responses-malformed-inputs.test.ts ✅ Passed 4.172s
tests/responses-not-found-errors.test.ts ✅ Passed 290ms
tests/responses-parse.test.ts ✅ Passed 635ms
tests/responses-retrieve-retries.test.ts ✅ Passed 893ms
tests/responses-retrieve.test.ts ✅ Passed 255ms
tests/responses-stored-method-errors.test.ts ✅ Passed 892ms
tests/retry-behavior.test.ts ✅ Passed 3.327s
tests/sdk-error-shape.test.ts ✅ Passed 428ms

View OkTest run #29625944702

SDK merge (c969cf733339) · head (4435e34c9d9f) · base (0522672d4994) · OkTest (fd7a761c81c1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant