fix: allow missing task and duration in diarized transcriptions#803
fix: allow missing task and duration in diarized transcriptions#803wskr00 wants to merge 4 commits into
Conversation
Signed-off-by: Lucas Christian <lucaschgf7@gmail.com>
Signed-off-by: Lucas Christian <lucaschgf7@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1703369d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * server responded with an unexpected value). | ||
| */ | ||
| fun duration(): Double = duration.getRequired("duration") | ||
| fun duration(): Optional<Double> = duration.getOptional("duration") |
There was a problem hiding this comment.
Preserve the duration getter's JVM descriptor
When an application or library compiled against the previous SDK invokes this getter after the SDK jar is upgraded without recompiling that caller, its bytecode still resolves duration()D, while this class now only provides duration()Ljava/util/Optional;; the invocation therefore fails at runtime with NoSuchMethodError, even when the response contains a duration. The primitive builder overload preserves the setter ABI, but the public getter needs equivalent compatibility handling (for example, retaining it and exposing the optional value under a new method name) or this change must be treated as a breaking release.
Useful? React with 👍 / 👎.
Signed-off-by: Lucas Christian <lucaschgf7@gmail.com>
|
About this:
Since the API can omit I would appreciate guidance on the team's preferred compatibility approach before changing the public API further. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c8d0d2db5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Lucas Christian <lucaschgf7@gmail.com>
Summary
Fixes diarized transcription response handling when optional fields are omitted by the API.
durationoptional inTranscriptionDiarized.taskfield while continuing to reject unexpected task values.Testing
./scripts/test./scripts/format./scripts/lintFixes #802