build(deps): patch test-only Logback dependencies#806
Merged
Conversation
jbeckwith-oai
marked this pull request as ready for review
July 20, 2026 20:48
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8cbdc427e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
reviewed
Jul 20, 2026
HAYDEN-OAI
approved these changes
Jul 20, 2026
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
looks good — i rechecked the narrowed current head and confirmed the spring expression constraint is gone; the logback constraints resolve only on the starter test classpaths and stay out of the pom, gradle module metadata, and runtime classpath.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses Dependabot alerts #21, #22, and #23.
Why
Spring Boot 2.7.18 resolves Logback 1.2.12, which is affected by CVE-2023-6378 and CVE-2023-6481.
The newer Logback 1.3/1.5 fixes are intentionally out of scope because they require the SLF4J 2 and Java 11 ecosystem. Logback 1.2.13 is the narrow patch compatible with Spring Boot 2.7 and SLF4J 1.7.
Spring Expression alert #29 was removed from this PR after review showed that a library-side constraint cannot reliably override an application's own Spring Boot 2.7 dependency-management rules for both Maven and Gradle consumers. It should be handled separately as part of a broader Spring Boot upgrade or an explicit consumer-level override.
Compatibility
Validation
./scripts/lint./scripts/build --rerun-tasks./scripts/test --rerun-tasks