fix(runTools): sanitize replayed messages#1990
Open
HAYDEN-OAI wants to merge 1 commit into
Open
Conversation
OkTest Summary❌ Failed for Node SDK PR #1990. SDK merge ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
runToolsreplays them in follow-up requestsrunner.messages, events, and parsed completions for callers while removing helper-onlyparsedandparsed_arguments, nullrefusal, and other response-only assistant fields from outbound payloadsAdditional context & links
Fixes #1161.
runToolscurrently stores parsed completion messages in its history and then sends that history back unchanged on the next tool-loop request. Azure and other strict-compatible endpoints reject the helper-only fields with errors such asAdditional properties are not allowed (parsed, refusal were unexpected).The fix sanitizes only the outbound copy, so existing parsed runner results remain available to users.
Verification:
pnpm test --runInBand tests/lib/ChatCompletionRunFunctions.test.tspnpm lintpnpm test --runInBand