fix(azure): normalize endpoint trailing slashes#1995
Open
HAYDEN-OAI wants to merge 2 commits into
Open
Conversation
OkTest Summary❌ Failed for Node SDK PR #1995. SDK merge ( |
apcha-oai
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AzureOpenAIendpoints before appending/openaiWhy
AzureClientOptions.endpointis documented with a trailing slash, but the constructor appended/openaidirectly. Passing the documented form produced a base URL such ashttps://example-resource.azure.openai.com//openai, which then carried the double slash into Azure request URLs.Impact
new AzureOpenAI({ endpoint: 'https://example-resource.azure.openai.com/' })now produceshttps://example-resource.azure.openai.com/openai. Endpoints without trailing slashes and callers that provide an explicitbaseURLkeep their existing behavior.Fixes #1669.
Validation
pnpm exec jest tests/lib/azure.test.ts --runInBandpnpm exec prettier --check src/azure.ts tests/lib/azure.test.tspnpm run lint