Handle surrogate pairs in unstable encoding#542
Open
shreejaykurhade wants to merge 1 commit into
Open
Conversation
shreejaykurhade
force-pushed
the
fix-surrogate-encoding
branch
from
5fe46bb to
88ce50e
Compare
shreejaykurhade
force-pushed
the
fix-surrogate-encoding
branch
from
88ce50e to
d3baea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541
encodeandencode_ordinaryalready retry with UTF-16 surrogate repair when the Rust core raisesUnicodeEncodeError.This applies the same behavior to
encode_with_unstable, so surrogate pairs and lone surrogates are handled consistently across Python encoding APIs.Added a regression test for
encode_with_unstable.Tested with: