fix(release): align npm trusted publisher identity - #188
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm-releaseGitHub environment so its OIDC identity has one explicit, documented environment claimThis repairs the repository side of #177. The npm package administrator still needs to update the private npmjs.com Trusted Publisher setting to match before the next release.
Proof
actionlint .github/workflows/release.ymlnpm trust github clawpatch --file release.yml --environment npm-release --allow-publish --dry-run --jsonpnpm typecheckpnpm lintpnpm format:checkpnpm test(29 files, 903 passed, 1 skipped)pnpm buildpnpm pack:smoke(13 features mapped, including 3 CUDA)No package was published and no release was created.