fix(docs): preserve text-run hyperlink URLs#920
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 13, 2026, 8:52 PM ET / July 14, 2026, 00:52 UTC. Summary Reproducibility: yes. at source level: current main appends ordinary text-run content without preserving Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Merge the focused traversal extension and its regression tests so Do we have a high-confidence way to reproduce the issue? Yes at source level: current main appends ordinary text-run content without preserving Is this the best way to solve the issue? Yes; extending the existing opt-in rendered traversal and additive JSON sidecar is the narrowest maintainable fix and avoids breaking default or AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against e4239f8c57a5. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
🦞🧹
This is fix-only; I will not merge this PR. Re-review progress:
|
|
🦞✅ Source: No actionable findings remain. I removed the repair-loop label and left the PR open for maintainer review and merge. Automerge progress:
|
Summary
TextRun.TextStyle.Link.Urlvalues in the existing rendered-text traversaldocs catand--plaintext unchanged--chipspath and expose additive structured link metadata in JSON[url](url)when visible text already equals the destinationScope
This intentionally covers external URL links on ordinary text runs. Heading and bookmark links remain out of scope. Smart-chip behavior, raw output, Docs export behavior, and unrelated formatting remain unchanged.
Validation
go test ./internal/cmdmake ciCloses #917
Related: #907 and #909
Thanks @neo-wanderer for the focused reproduction and @TurboTheTurtle for the adjacent smart-chip rendering foundation.