feat(registry): add promise-first adapter APIs - #1549
Open
ricardo-devis-agullo wants to merge 3 commits into
Open
feat(registry): add promise-first adapter APIs#1549ricardo-devis-agullo wants to merge 3 commits into
ricardo-devis-agullo wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds promise-first storage and metadata adapter contracts while retaining callback compatibility for official and custom adapters.
Changes:
- Adds dual promise/callback adapter types and deprecation warnings.
- Normalizes legacy adapters for registry internals.
- Updates official adapters and expands runtime/type coverage.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/oc/test/unit/registry-domain-validator.js |
Tests callback metadata validation. |
packages/oc/test/unit/registry-domain-storage-adapter.js |
Tests storage normalization and warnings. |
packages/oc/test/unit/registry-domain-repository.js |
Tests callback metadata repository usage. |
packages/oc/test/unit/registry-domain-metadata-adapter.js |
Tests metadata normalization. |
packages/oc/test/types/adapter-registration.ts |
Exercises adapter type contracts. |
packages/oc/src/types.ts |
Accepts promise or legacy adapters. |
packages/oc/src/registry/domain/validators/registry-configuration.ts |
Normalizes metadata during validation. |
packages/oc/src/registry/domain/storage-adapter.ts |
Normalizes legacy storage adapters. |
packages/oc/src/registry/domain/repository.ts |
Normalizes repository metadata stores. |
packages/oc/src/registry/domain/metadata-adapter.ts |
Adds metadata adapter normalization. |
packages/oc/src/cli/facade/registry-migrate-metadata.ts |
Normalizes migration metadata stores. |
packages/oc-storage-adapters-utils/src/index.ts |
Adds storage callback compatibility types. |
packages/oc-s3-storage-adapter/test/s3.test.ts |
Tests S3 callback compatibility. |
packages/oc-s3-storage-adapter/src/index.ts |
Adds dual S3 methods. |
packages/oc-metadata-adapters-utils/src/index.ts |
Adds metadata callback compatibility types. |
packages/oc-gs-storage-adapter/test/gs.test.ts |
Tests GS callback compatibility. |
packages/oc-gs-storage-adapter/src/index.ts |
Adds dual GS methods. |
packages/oc-azure-table-metadata-adapter/test/index.js |
Tests Azure Table callbacks. |
packages/oc-azure-table-metadata-adapter/src/index.ts |
Adds dual Azure Table methods. |
packages/oc-azure-storage-adapter/test/azure.test.ts |
Tests Azure Blob callbacks. |
packages/oc-azure-storage-adapter/src/index.ts |
Adds dual Azure Blob methods. |
packages/oc-azure-sql-metadata-adapter/test/index.js |
Tests Azure SQL callbacks. |
packages/oc-azure-sql-metadata-adapter/src/index.ts |
Adds dual Azure SQL methods. |
Suppressed comments (1)
packages/oc/src/registry/domain/metadata-adapter.ts:101
- The unmarked-adapter path also loses a prototype-defined
adapterTypebecause object spread only copies own enumerable properties. Explicitly retain this required field so class-based custom stores still satisfyMetadataStoreafter normalization.
...adapter,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+73
to
+74
| ...adapter, | ||
| adapterApi: 'promise', |
Comment on lines
+26
to
+27
| ...adapter, | ||
| adapterApi: 'promise', |
Comment on lines
+47
to
+66
| if (typeof callback !== 'function') { | ||
| return Promise.resolve().then(() => fn(...(arguments_ as Arguments))); | ||
| } | ||
|
|
||
| warnAboutCallbacks(adapterId); | ||
| arguments_.pop(); | ||
| let settled = false; | ||
| const finish = (error: unknown, value?: ReturnValue) => { | ||
| if (settled) { | ||
| return; | ||
| } | ||
| settled = true; | ||
| (callback as AdapterCallback<ReturnValue>)(error, value); | ||
| }; | ||
|
|
||
| try { | ||
| fn(...(arguments_ as Arguments)).then( | ||
| (value) => finish(null, value), | ||
| (error) => finish(error) | ||
| ); |
Comment on lines
+49
to
+68
| if (typeof callback !== 'function') { | ||
| return Promise.resolve().then(() => fn(...(arguments_ as Arguments))); | ||
| } | ||
|
|
||
| warnAboutCallbacks(adapterId); | ||
| arguments_.pop(); | ||
| let settled = false; | ||
| const finish = (error: unknown, value?: ReturnValue) => { | ||
| if (settled) { | ||
| return; | ||
| } | ||
| settled = true; | ||
| (callback as MetadataAdapterCallback<ReturnValue>)(error, value); | ||
| }; | ||
|
|
||
| try { | ||
| fn(...(arguments_ as Arguments)).then( | ||
| (value) => finish(null, value), | ||
| (error) => finish(error) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements the V1.md Track 1, non-breaking 0.x promise-first storage and metadata adapter groundwork.
Closes #1548
Test plan
npx turbo run lint --filter=oc-storage-adapters-utils --filter=oc-metadata-adapters-utils --filter=oc-s3-storage-adapter --filter=oc-gs-storage-adapter --filter=oc-azure-storage-adapter --filter=oc-azure-sql-metadata-adapter --filter=oc-azure-table-metadata-adapter --filter=ocnpx turbo run test-silent --filter=oc-storage-adapters-utils --filter=oc-metadata-adapters-utils --filter=oc-s3-storage-adapter --filter=oc-gs-storage-adapter --filter=oc-azure-storage-adapter --filter=oc-azure-sql-metadata-adapter --filter=oc-azure-table-metadata-adapter --filter=ocnpx mocha test/unit/registry-domain-storage-adapter.js test/unit/registry-domain-metadata-adapter.jsfrompackages/ococsuite: 997 passing