Optimized Forwarding Headers#2285
Open
JaiOCP wants to merge 3 commits into
Open
Conversation
JaiOCP
commented
May 20, 2026
| SAI_IN_DROP_REASON_LPM_MISS = 0x00000039, | ||
|
|
||
| /** OFH packet TTL expired */ | ||
| SAI_IN_DROP_REASON_OFH_TTL, |
Contributor
Author
There was a problem hiding this comment.
Keep it consistent with IP or not ?
| SAI_SWITCH_ATTR_OFH, | ||
|
|
||
| /** | ||
| * @brief OFH header max size |
Contributor
Author
There was a problem hiding this comment.
Improve comments to explian the use of max size supported by HW.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@JaiOCP validator is not handling merges, you will need to rebase your change on master and force push |
Contributor
Author
|
Sounds Good. I will recreate the PR as well. Too many changes have gone in
mainline.
…On Thu, May 21, 2026 at 1:06 PM Kamil Cudnik ***@***.***> wrote:
*kcudnik* left a comment (opencomputeproject/SAI#2285)
<#2285 (comment)>
@JaiOCP <https://github.com/JaiOCP> validator is not handling merges, you
will need to rebase your change on master and force push
—
Reply to this email directly, view it on GitHub
<#2285 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKCSHLLXBLZHRZQUZVKIL53435OTDAVCNFSM6AAAAACY6TZJW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMJSGM2DAMZYGU>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
you dont need to recreate, you can jsut rebase and force push to your branch |
Collaborator
|
you need to squash and force push |
| * @default 0 | ||
| * @validonly SAI_OFH_ATTR_TYPE == SAI_OFH_TYPE_AFH_TYPE_1 or SAI_OFH_ATTR_TYPE == SAI_OFH_TYPE_AFH_TYPE_2 | ||
| */ | ||
| SAI_OFH_ATTR_VER_OFFSET, |
There was a problem hiding this comment.
Some headers have their format defined by the version field. While the ofh_type may be the same, the actual header format can differ depending on the version.
For example, the next version of ESUN will likely share the same Ethertype as the current version, but the header format will be determined by the value of the version (RevisionNumber) field.
To handle these cases, add a version enum attribute. This attribute specifies which version of the OFH is being defined.
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> OFH Support Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Fix gensairpc.pl crash on Doxygen 1.9.8+ by reusing NeedsTwoPassProcessing (opencomputeproject#2282) Why: To fix below build error Uncaught exception from user code: at gensairpc.pl line 480. main::assign_attr_types(HASH(0x55e190dc20c8), ARRAY(0x55e190d2d080)) called at gensairpc.pl line 434 main::get_definitions() called at gensairpc.pl line 156 main::assign_attr_types(HASH(0x55e190dc20c8), ARRAY(0x55e190d2d080)) called at gensairpc.pl line 434 main::get_definitions() called at gensairpc.pl line 156 How: gensairpc.pl crashed during SAI thrift build with an uncaught exception at line 480 (assign_attr_types) because its inline Doxygen layout detection was too weak - it only checked sai_8h.xml for any enumvalue presence, missing cases where the new Doxygen 1.9.8+ XML structure requires group__*.xml files to be processed for complete definitions. This caused incomplete parsing, leading to missing types and a croak in assign_attr_types when sai_attribute_value_t could not be found. Changes: - xmlutils.pm: Add NeedsTwoPassProcessing and export it. - parse.pl: Remove local NeedsTwoPassProcessing; use imported version. - gensairpc.pl: Replace inline detection with NeedsTwoPassProcessing() call, fixing the build failure and eliminating code duplication. Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com> OFH Header Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Count BFD session state changes from UP to DOWN (opencomputeproject#2268) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> HW FRR switchover notification support for protection groups (opencomputeproject#2269) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> Port storm control enhancemnets (opencomputeproject#2258) (opencomputeproject#2258) Signed-off-by: rpmarvell <rperumal@marvell.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings a generic framework to support multiple activities going on for defining the Optimized Forwarding Header like IEEE compressed Header, OCP ESUN Header, UEC Unified Forwarding Header and more.