RT-1.15 adding SendMaxUnsupported deviation and community_member_regex_unsupported

[fmolinar]

rt-1.15 Summary
Single commit: b2a396e — "adding SendMaxUnsupported deviation and using community_member_regex_unsupported"

Changes across 5 files:

1. New deviation: SendMaxUnsupported

proto/metadata.proto — Added field send_max_unsupported = 395 for devices that don't support BGP add-path send-max configuration
internal/deviations/deviations.go — Added SendMaxUnsupported() helper function
proto/metadata_go_proto/metadata.pb.go — Regenerated protobuf (bulk of the line changes)
2. Test updates: addpath_scale_test.go

Added Desc fields to all 8 port attributes (dutPort1-4, atePort1-4)
Wrapped SetSendMax(10) in a !deviations.SendMaxUnsupported(dut) guard (line 507-509)
Fixed community set CLI format — removed \n before end-set in the regex community set config for Cisco
3. Metadata: metadata.textproto

Enabled both community_member_regex_unsupported: true and send_max_unsupported: true for the Cisco platform exception
TL;DR
The branch adds a Cisco-specific deviation to skip send-max configuration in BGP add-path (unsupported on XR 8000), fixes the community-set CLI syntax for Cisco, and adds port descriptions.

[OpenConfigBot]

Pull Request Functional Test Report for #5293 / eaeb2d3

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.15: BGP Addpath on scale with and without routing policy
Cisco 8000E		RT-1.15: BGP Addpath on scale with and without routing policy
Cisco XRd		RT-1.15: BGP Addpath on scale with and without routing policy
Juniper ncPTX		RT-1.15: BGP Addpath on scale with and without routing policy
Nokia SR Linux		RT-1.15: BGP Addpath on scale with and without routing policy
Openconfig Lemming		RT-1.15: BGP Addpath on scale with and without routing policy

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.15: BGP Addpath on scale with and without routing policy
Cisco 8808		RT-1.15: BGP Addpath on scale with and without routing policy
Juniper PTX10008		RT-1.15: BGP Addpath on scale with and without routing policy
Nokia 7250 IXR-10e		RT-1.15: BGP Addpath on scale with and without routing policy

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces platform-specific deviations to improve compatibility with Cisco devices in BGP add-path testing. It adds a new configuration flag to skip unsupported send-max settings, fixes a syntax issue in community-set CLI commands, and enhances test readability by adding descriptive labels to network ports.

Highlights

• New Deviation: SendMaxUnsupported: Introduced a new deviation to handle devices that do not support BGP add-path send-max configuration, specifically for Cisco platforms.
• Test Improvements: Updated the addpath_scale_test.go file to include port descriptions for all DUT and ATE ports and implemented a guard for the send-max configuration.
• CLI Syntax Fix: Corrected the community-set CLI syntax for Cisco devices by removing an unnecessary newline character.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new deviation, send_max_unsupported, to handle devices that do not support BGP add-path send-max configuration. The changes include adding the field to the metadata protobuf, implementing an accessor in the deviations package, and updating the scale test to conditionally apply the configuration. Additionally, the PR fixes a CLI formatting issue for Cisco community sets and adds descriptions to port attributes. Feedback was provided to improve the documentation in the protobuf definition to focus on the field's purpose rather than the accessor function's return value.

[fmolinar]

hi @AmrNJ
I don't see anymore comments that need action, lmk if this PR is good to go and can be merged into main.
thanks,
Fernando