feat: bind the html viewport config for java and python

[andiwand]

🤖 Generated with Claude Code

HtmlConfig::viewport_mode, spreadsheet_viewport_mode and viewport_content had no bindings, so the mobile initial zoom was stuck on whatever automatic resolved to — unreachable from OpenDocument.droid, which is the consumer the option exists for.

Java

• new HtmlViewportMode (AUTOMATIC, FIT_WIDTH, ACTUAL_SIZE, NONE), constant order matching the C++ enum
• HtmlConfig.viewportMode / .spreadsheetViewportMode / .viewportContent, marshalled both ways in jni_style.cpp. The two optionals follow the existing convention: null ↔ std::nullopt, via the -1 enum ordinal for the mode and make_string_opt/get_string_opt for the raw content.

Python

• pyodr.HtmlViewportMode plus the three def_readwrites; pybind11/stl.h is already included, so the optionals cross as None.

Tests

test/src/internal/html/common_test.cpp already covers the mode matrix, so the new tests only prove the config crosses the bindings: a round trip through HtmlService.config() and the <meta name="viewport"> an odt actually renders with, in both suites.

Verified locally: odr_jni_junit (7/7 in HtmlTest, none skipped) and pytest python/tests/test_html.py (8 passed).

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[Copilot]

Pull request overview

This PR exposes the existing C++ HTML viewport configuration (HtmlViewportMode and HtmlConfig’s viewport fields) through the Java (JNI) and Python bindings, enabling mobile clients (notably OpenDocument.droid) to control the generated <meta name="viewport"> behavior instead of being locked to the default automatic resolution.

Changes:

• Added HtmlViewportMode enum bindings for both Python (pyodr.HtmlViewportMode) and Java (app.opendocument.core.HtmlViewportMode).
• Bound HtmlConfig.viewportMode, HtmlConfig.spreadsheetViewportMode (nullable), and HtmlConfig.viewportContent across JNI and pybind11.
• Added Java and Python tests to validate that viewport config round-trips through bindings and affects rendered HTML output.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
python/tests/test_html.py	Adds Python-level regression tests for viewport defaults and emitted viewport meta tag.
python/src/bind_html.cpp	Exposes HtmlViewportMode and HtmlConfig viewport fields via pybind11.
jni/tests/app/opendocument/core/HtmlTest.java	Adds JNI tests for viewport defaults, round-trip config, and emitted viewport meta tag.
jni/src/jni_style.cpp	Marshals viewport-related fields between odr::HtmlConfig and Java HtmlConfig.
jni/java/app/opendocument/core/HtmlViewportMode.java	Introduces Java enum mirroring odr::HtmlViewportMode ordinal mapping.
jni/java/app/opendocument/core/HtmlConfig.java	Adds Java-facing viewport configuration fields (mode, spreadsheet override, raw content).
jni/CMakeLists.txt	Includes the new HtmlViewportMode.java in the Java build.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.