refactor(crypto): implement argon2id in-tree, drop conan-odr-index - #655
Merged
Conversation
The argon2 package was the last recipe we carried in conan-odr-index that ConanCenter does not have. It only existed because upstream's Makefile cannot cross-compile for Android, and ConanCenter declined the fix since upstream has been unmaintained since 2021. Argon2id on top of Crypto++'s BLAKE2b is ~300 lines, so implement it rather than swap in another crypto library: Crypto++ has no Argon2, libsodium hardcodes p=1 while LibreOffice writes p=4, and Botan/OpenSSL would be a second full crypto stack. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZSnvAQFbn3MsD5tt5JGz3
argon2 was the last recipe this repo pulled from it; everything else resolves from ConanCenter. CI no longer checks the submodule out or exports it, and the conan cache keys lose the submodule sha. The index itself stays where it is — other repos still use it, and its odrcore recipe still serves released 5.x. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZSnvAQFbn3MsD5tt5JGz3
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZSnvAQFbn3MsD5tt5JGz3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
argon2/20190702-odrwas the last recipe this repo pulled fromconan-odr-index. It only existed because upstream's Makefile cannot cross-compile for Android, and ConanCenter declined to carry the fix — upstream has been unmaintained since 2021, so the patch would never go away. (Proposed upstream anyway: P-H-C/phc-winner-argon2#392.)We use exactly one function of it, so this implements Argon2id in
crypto_argon2.*(~300 lines) on top of Crypto++'s BLAKE2b instead of taking on another dependency:p=1; LibreOffice writesp=4util::argon2idkeeps its signature, so nothing abovecrypto/changes. Bad parameters now throwstd::invalid_argumentinstead of silently returning zeros, which is whatargon2id_hash_raw's ignored return code used to do.With that gone, everything resolves from ConanCenter, so the second commit drops the
conan-odr-indexsubmodule: no more checkout/export steps in the six workflows that had them, and the conan cache keys lose the submodule sha. The index itself stays where it is — other repos still use it, and itsodrcorerecipe still serves released 5.x.Verification
t=3, m=65536, p=4.conan graph info . --lockfile conan.lockresolves from a clean conan home with onlyconancenter, for both the default and theandroid-armv8host profile.Sequential lanes, so no threading: ~66 ms vs ~28 ms for LibreOffice's parameters, once per document open.