Skip to content

Refuse a two-part version here too, not six minutes in #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andiwand merged 1 commit into from
Aug 4, 2026
Merged

Refuse a two-part version here too, not six minutes in #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/scripts/resolve-version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@
import re
import sys

# what app/build.gradle accepts: an optional v, one to three parts, each below
# 100 so that two digits per part stays unambiguous
VERSION = re.compile(r"^v?[0-9]{1,2}(\.[0-9]{1,2}){0,2}$")
# what app/build.gradle accepts: an optional v, all three parts, each below 100 so
# that two digits per part stays unambiguous. Two-part versions were once padded
# with a zero, which let one build be tagged under two names; the build refuses
# them now, and this has to refuse the same ones or it stops being a check
VERSION = re.compile(r"^v?[0-9]{1,2}(\.[0-9]{1,2}){2}$")


def fail(message):
Expand Down Expand Up @@ -70,7 +72,8 @@ def resolve(tag, given, uploads, log=print):

if not VERSION.match(version):
raise ValueError(
f"'{version}' is not a version: expected something like v4.8.0, each part below 100"
f"'{version}' is not a version: expected something like v4.8.0 - all "
"three parts, each below 100"
)
log(f"building {version}")
return version
Expand Down
Loading