Skip to content

refactor: remove course taxonomy permissions#157

Open
bra-i-am wants to merge 1 commit into
openedx:masterfrom
eduNEXT:bc/remove-taxonomy-permission
Open

refactor: remove course taxonomy permissions#157
bra-i-am wants to merge 1 commit into
openedx:masterfrom
eduNEXT:bc/remove-taxonomy-permission

Conversation

@bra-i-am
Copy link
Copy Markdown
Contributor

@bra-i-am bra-i-am commented Jun 3, 2026

Removes the manage_taxonomies permission from the UI as decided in openedx/openedx-authz#309

The course admin can manage tags, but can't manage taxonomy (it is not related to a course role); the content tagging will have its own permissions.

Closes openedx/openedx-authz#309

Changes

  • Removed MANAGE_COURSE_TAXONOMIES from the CONTENT_COURSE_PERMISSIONS enum
  • Removed the "Manage taxonomies" entry from the permissions list rendered in the UI
  • Removed MANAGE_COURSE_TAXONOMIES from the course_admin role definition
  • Updated the "Tags & taxonomies" resource group label to "Tags"

Applied to both authz-module/constants.ts and roles-permissions/course/constants.ts.

Screenshot

image

Pending

The permission also needs to be removed from openedx-authz (constant definition and role policy assignment).

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.64%. Comparing base (3a3d22b) to head (1e57c40).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files          68       68           
  Lines        1572     1572           
  Branches      368      396   +28     
=======================================
  Hits         1535     1535           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✨

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 4, 2026
Copy link
Copy Markdown

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

Remove the manage taxonomy permission from the UI

5 participants