feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path#547
Draft
kdmccormick wants to merge 3 commits intokdmccormick/keys-reffrom
Draft
feat!: ComponentVersionMedia.key -> ComponentVersionMedia.path#547kdmccormick wants to merge 3 commits intokdmccormick/keys-reffrom
kdmccormick wants to merge 3 commits intokdmccormick/keys-reffrom
Conversation
This was referenced Apr 15, 2026
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
3 times, most recently
from
0b01361 to
52fe205
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
ca5d407 to
bb6edbd
Compare
Comment on lines
+8
to
+11
| Rename the underlying DB column for ComponentVersionMedia.path from | ||
| '_key' to 'path'. Uses SeparateDatabaseAndState with RunSQL for | ||
| SQLite/MySQL compatibility. The table is named | ||
| 'openedx_content_componentversionmedia' (Django default). |
Contributor
There was a problem hiding this comment.
Why do we need RunSQL here instead of just AlterField() to change the db_column?
BREAKING CHANGE: Renamed ComponentVersionMedia.key -> ComponentVersionMedia.path
BREAKING CHANGE: In create_component_version_media(...) and
look_up_component_version_media(...), renamed param key -> path.
Part of: #322
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Field Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kdmccormick
force-pushed
the
kdmccormick/keys-ref
branch
from
52fe205 to
b9d11db
Compare
kdmccormick
force-pushed
the
kdmccormick/keys-media
branch
from
bb6edbd to
64d820e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed ComponentVersionMedia.key -> ComponentVersionMedia.path
BREAKING CHANGE: In create_component_version_media(...) and
look_up_component_version_media(...), renamed param key -> path.
Part of: #322
Full series of PRs:
keysare now opaquerefs#546Testing
TBC
AI disclosure
Claude helped me write this PR. See #322 for details.