Document line shunt susceptance in lines_df#702
Draft
sapunyangkut wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the missing
bentry to theTopology.lines_dfdocstring, documenting line shunt susceptance in Siemens and the total value for parallel lines. This follows the actualCOLUMNS["lines_df"]order and avoids the issue's outdated suggestion thatbis always zero; the current implementation can compute it from a line type'sC_per_km.Fixes #653
Type of change
Checklist
lines_dfcolumn in implementation order.git diff --check, Python compilation, AST parsing, and an exact docstring-column coverage assertion pass.pre-commitand Sphinx were unavailable in the local environment; repository CI is requested for those checks.tests/conftest.pyimports unavailablematplotlib.AI assistance
This change was prepared with AI assistance and submitted through an automated contribution workflow. The final wording and diff were checked against the pinned eDisGo source, the current data-model documentation, and the issue acceptance criteria.