Fix OPF time_elapsed calculation - #708
Open
jldonner wants to merge 1 commit into
Open
Conversation
Collaborator
|
@jldonner Can you write a test for this function? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the calculation of
time_elapsedinedisgo/io/powermodels_io.pywhen converting an eDisGo/PyPSA network to the PowerModels format.Previously,
time_elapsedwas derived using.secondsand cast toint:This caused incorrect values for several valid snapshot resolutions:
15-minute snapshots resulted in time_elapsed = 0 instead of 0.25
24-hour gaps resulted in time_elapsed = 0
25-hour gaps resulted in time_elapsed = 1 instead of 25
Since time_elapsed is used in the Julia OPF formulation for inter-temporal constraints, this could decouple power and energy variables for batteries, heat storage, DSM, and EV charging.
The fix introduces an internal helper function _get_time_elapsed_in_hours(snapshots) which:
Fixes #693
Type of change
Checklist: