fix: correctly construct default output filename for datasets and binary mode#32
Open
Ayush-AM wants to merge 1 commit into
Open
Conversation
0561ceb to
28268e0
Compare
Signed-off-by: Ayush Mahajan <140263932+Ayush-AM@users.noreply.github.com>
28268e0 to
25e0a06
Compare
Author
|
Hi @alexgubanow, I've opened this PR to resolve issue #22 regarding the output filename generation. Here is a summary of the fixes implemented for both the Java and C++ versions:
(Note: There was a brief issue with the DCO check due to a branch sync mismatch, but I have rebased the PR against Please let me know if everything looks good or if any further adjustments are needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Description of changes
This PR addresses the issue where the default output filename was poorly constructed when providing a z/OS dataset name (e.g.,
//'my.data.set') and didn't correctly use the.binextension in binary mode.Key updates
.binextension when the-b(binary) flag is used, rather than requiring manual output specification or defaulting to.txt.//and/or enclosed in single quotes' '(e.g.,//'my.data.set'), the tool now strips the slashes and quotes before appending the appropriate extension. This results in a clean output filename likemy.data.set.binormy.data.set.txt.Testing Performed
java -jar target/tersedecompress.jar -b "//'my.data.set'"correctly attempts to output to a sanitized file namedmy.data.set.bin.