Fix guesst() sigEmax label and refactor internal model handling - #49
Merged
Conversation
Bug fix: * guesst(): the sigEmax steepness parameter returned for 3+ dose-response pairs was mislabeled "delta" instead of "h", inconsistent with the 2-pair branch and the rest of the package. Internal refactoring (no changes to function inputs/outputs): * Centralize built-in model metadata: add internal builtInMods (model names) and nParMod (parameter counts) in drmodels.R and use them in fitMod, fitMod_helpers, maFitMod, MCPMod, Mods_helpers (checkEntries) and optDesign_helpers (nPars), removing several hard-coded copies. bFitMod keeps its own C-coupled ordering (now documented). * Deduplicate the lg2() and xlogx() helpers: define them once in drmodels.R and drop the inline copies in sigEmaxGrad, betaMod and betaModGrad. * Replace 1:length(x) / 1:nrow() / 1:ncol() idioms with seq_along() / seq_len() across the package for zero-length robustness. All 596 testthat tests pass (0 failures, 0 warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix:
Internal refactoring (no changes to function inputs/outputs):
All 596 testthat tests pass (0 failures, 0 warnings).