Skip to content

OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-metal3:masterfrom
bfournie:ui-ps-checkbox
Apr 7, 2026
Merged

OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881
openshift-merge-bot[bot] merged 1 commit intoopenshift-metal3:masterfrom
bfournie:ui-ps-checkbox

Conversation

@bfournie
Copy link
Copy Markdown
Contributor

@bfournie bfournie commented Apr 3, 2026

The OVE UI cluster details page now has a checkbox in order to enter the pull secret. This adds support for it to the UI-driven installation.

In addition, in order to improve debugging on this page, and other pages, a screenshot is taken when entering the page and prior to leaving the page.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 3, 2026

/cc @andfasano
/cc @rwsu

@openshift-ci openshift-ci bot requested review from andfasano and rwsu April 3, 2026 20:20
@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 3, 2026

Confirmed that checkbox is now used and installation is successful

time="2026-04-03T21:06:10+02:00" level=info msg="Enter cluster details"
time="2026-04-03T21:06:11+02:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/01-cluster-details-start-20260403-210611.png, with type of image/png"
time="2026-04-03T21:06:13+02:00" level=info msg="Found 'Edit pull secret' checkbox, clicking to reveal field..."
time="2026-04-03T21:06:15+02:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/01-cluster-details-after-checkbox-20260403-210615.png, with type of image/png"
time="2026-04-03T21:06:26+02:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/01-cluster-details-end-20260403-210626.png, with type of image/png"
time="2026-04-03T21:06:26+02:00" level=info msg="Waiting for operators page to load..."

Comment thread agent/isobuilder/ui_driven_cluster_installation/main.go Outdated
Comment thread agent/isobuilder/ui_driven_cluster_installation/main.go Outdated
@rwsu
Copy link
Copy Markdown
Contributor

rwsu commented Apr 5, 2026

/retest-required

The OVE UI cluster details page now has a checkbox in order to
enter the pull secret. This adds support for it to the UI-driven
installation.

In addition, in order to improve debugging on this page, and other
pages, a screenshot is taken when entering the page and prior to
leaving the page.
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

@bfournie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack c4c3489 link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 6, 2026

/test e2e-agent-compact-ipv4-iso-no-registry

Copy link
Copy Markdown
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2026
@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 6, 2026

/override ci/prow/e2e-agent-compact-ipv4
due to https://redhat.atlassian.net/browse/OCPBUGS-81627

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/e2e-agent-compact-ipv4

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4
due to https://redhat.atlassian.net/browse/OCPBUGS-81627

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 6, 2026

/cc @zaneb

@openshift-ci openshift-ci bot requested a review from zaneb April 6, 2026 22:10
@zaneb
Copy link
Copy Markdown
Member

zaneb commented Apr 7, 2026

This looks ok since we are always building an ISO locally with an embedded ignition that does not contain a pull secret.
If we start were to start testing the flow where assisted-service embeds the ignition including the pull secret, we would want to stop editing (and also screenshotting) it.

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit ec17268 into openshift-metal3:master Apr 7, 2026
9 of 10 checks passed
@bfournie bfournie deleted the ui-ps-checkbox branch April 7, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants