OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881
Conversation
|
/cc @andfasano |
|
Confirmed that checkbox is now used and installation is successful |
|
/retest-required |
The OVE UI cluster details page now has a checkbox in order to enter the pull secret. This adds support for it to the UI-driven installation. In addition, in order to improve debugging on this page, and other pages, a screenshot is taken when entering the page and prior to leaving the page.
|
@bfournie: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/override ci/prow/e2e-agent-compact-ipv4 |
|
@bfournie: Overrode contexts on behalf of bfournie: ci/prow/e2e-agent-compact-ipv4 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @zaneb |
|
This looks ok since we are always building an ISO locally with an embedded ignition that does not contain a pull secret. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ec17268
into
openshift-metal3:master
The OVE UI cluster details page now has a checkbox in order to enter the pull secret. This adds support for it to the UI-driven installation.
In addition, in order to improve debugging on this page, and other pages, a screenshot is taken when entering the page and prior to leaving the page.