Rename "Insights Advisor" to "Red Hat Lightspeed Advisor" in API docs

[Jakub007d]

Rename all "Insights Advisor" references in API field descriptions to "Red Hat Lightspeed Advisor" across operator/v1, insights/v1, insights/v1alpha1, and insights/v1alpha2 types.
The generated swagger docs, CRD manifests, and OpenAPI specs were updated with make update.

Ref: https://redhat.atlassian.net/browse/HCCDOC-4522

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @Jakub007d! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

Hi @Jakub007d. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 53cb28fc-a540-4d05-85d8-076045ebf11e

📥 Commits

Reviewing files that changed from the base of the PR and between 212a921 and 9e961bd.

⛔ Files ignored due to path filters (14)

• insights/v1/zz_generated.crd-manifests/0000_10_insights_01_datagathers.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• insights/v1/zz_generated.featuregated-crd-manifests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• insights/v1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• insights/v1alpha1/zz_generated.crd-manifests/0000_10_insights_01_datagathers.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• insights/v1alpha1/zz_generated.featuregated-crd-manifests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• insights/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• insights/v1alpha2/zz_generated.crd-manifests/0000_10_insights_01_datagathers.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• insights/v1alpha2/zz_generated.featuregated-crd-manifests/datagathers.insights.openshift.io/InsightsOnDemandDataGather.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• insights/v1alpha2/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*
• openapi/openapi.json is excluded by !openapi/**
• operator/v1/zz_generated.crd-manifests/0000_50_insights_00_insightsoperators.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.featuregated-crd-manifests/insightsoperators.operator.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*

📒 Files selected for processing (5)

• insights/v1/types_insights.go
• insights/v1alpha1/types_insights.go
• insights/v1alpha2/types_insights.go
• operator/v1/types_insights.go
• payload-manifests/crds/0000_10_insights_01_datagathers.crd.yaml

🚧 Files skipped from review as they are similar to previous changes (5)

• insights/v1alpha2/types_insights.go
• payload-manifests/crds/0000_10_insights_01_datagathers.crd.yaml
• insights/v1alpha1/types_insights.go
• insights/v1/types_insights.go
• operator/v1/types_insights.go

---

📝 Walkthrough

Walkthrough

Updated HealthCheck Advisor documentation across insights/v1, insights/v1alpha1, insights/v1alpha2, and operator/v1, along with the corresponding CRD schema description. References to “Insights Advisor” now use “Red Hat Lightspeed Advisor,” including related UI wording. Field definitions, JSON tags, validation markers, and behavior remain unchanged.

Suggested reviewers: everettraven, joelspeed

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: renaming Insights Advisor to Red Hat Lightspeed Advisor in API docs.
Description check	✅ Passed	The description is directly related to the changeset and correctly mentions the updated API docs and generated outputs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only updates comments/generated docs; no Ginkgo test declarations or titles were added or changed in the touched files.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed; the commit only updates API doc comments and generated manifests, so the test-structure checklist is not applicable.
Microshift Test Compatibility	✅ Passed	Changes touch only API docs/generated manifests; no test files or Ginkgo declarations were added, so MicroShift compatibility is unaffected.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only changes comments and generated docs/manifests, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only API/CRD/OpenAPI documentation strings changed; no deployment manifests, controllers, replicas, affinity, selectors, or topology logic were modified.
Ote Binary Stdout Contract	✅ Passed	PASS: The diff only renames field docs in type/comment and generated schema files; no main/init/suite setup code or stdout/logging writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo/e2e tests were added; the diff only changes API docs and generated manifests/comments, with no IPv4 or external-network test code.
No-Weak-Crypto	✅ Passed	PR only changes documentation comments and generated text for AdvisorURI/state; no crypto code, weak algorithms, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	Diff only renames Advisor text in comments/CRD docs; no privileged/hostPID/hostNetwork/SYS_ADMIN/allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only updates API/CRD/OpenAPI descriptions; no log statements or new sensitive data exposure were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[michelle-purcell]

@jakub - I reviewed the PR from the docs perspective for Red Hat style and grammar guidelines. Looks great. Just a few comments and suggestions. Thank you for your help with these updates 😄

[michelle-purcell]

/lgtm - my comments are non-critcal.

[JoelSpeed]

I'm not necessarily familiar with what's happened on the rebrand here, is Insights Advisor always Lightspeed advisor UI now?

[michelle-purcell]

I'm not necessarily familiar with what's happened on the rebrand here, is Insights Advisor always Lightspeed advisor UI now?

Yes. It's the Red Hat Lightspeed Advisor UI (and it's Red Hat Lightspeed advisor service (lowercase a in this context)

[JoelSpeed]

/lgtm
/verified by CI

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/ok-to-test

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, michelle-purcell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD a3d85be and 2 for PR HEAD 212a921 in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD fa22e69 and 1 for PR HEAD 212a921 in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD d8a1748 and 0 for PR HEAD 212a921 in total

[openshift-ci]

@Jakub007d: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview	212a921	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift-conformance	212a921	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-serial-techpreview-2of2	212a921	link	true	/test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-azure	212a921	link	true	/test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-bot]

/hold

Revision 212a921 was retested 3 times: holding

[JoelSpeed]

You'll need to run PROTO_OPTIONAL=1 make update to generate the out-of-date content here

[openshift-ci]

New changes are detected. LGTM label has been removed.