[WIP] Promote IrreconcilableMachineConfig to GA

[proietfb]

This PR promotes the IrreconcilableMachineConfig feature gate from DevPreview/TechPreview to Default feature set.

Ref: OCPSTRAT-1215 and PR#6085 Test Suite

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @proietfb! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 68bddb50-ecc9-4928-b555-b1285298d358

📥 Commits

Reviewing files that changed from the base of the PR and between 875e8ba and f73a676.

⛔ Files ignored due to path filters (7)

• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• operator/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (7)

• payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigurations-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigurations-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigurations-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigurations-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_machineconfigurations.crd.yaml

💤 Files with no reviewable changes (1)

• payload-manifests/crds/0000_80_machine-config_01_machineconfigurations.crd.yaml

---

📝 Walkthrough

Walkthrough

IrreconcilableMachineConfig is enabled for default and OKD configurations, with corresponding feature-gate manifests moving it from disabled to enabled lists. The feature table row is repositioned, and the CustomNoUpgrade annotation is removed from the MachineConfigurations CRD. MachineConfigNode CRD schemas now define optional status.irreconcilableChanges entries with validation constraints.

Suggested reviewers: joelspeed, everettraven

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the main change: promoting IrreconcilableMachineConfig, with only minor WIP noise.
Description check	✅ Passed	The description is directly related to the feature gate promotion and cites the relevant work items.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only changes feature-gate manifests/config and generated CRDs; no _test.go files or Ginkgo titles are modified.
Test Structure And Quality	✅ Passed	PASS: The PR only changes manifests/CRDs; no Ginkgo test files or It/BeforeEach/Eventually code were added or modified, so the check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes CRD/feature-gate manifests, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added or modified; the diff only touches generated CRD/manifests, so no SNO-specific assumptions were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CRD/status and feature-gate manifest changes; no nodeSelector, affinity, topologySpread, replica, or control-plane targeting was introduced.
Ote Binary Stdout Contract	✅ Passed	The PR changes only YAML manifests; no Go main/init/TestMain code was touched, and no stdout-writing patterns appeared in changed files.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	HEAD only changes generated feature/CRD manifests; no new Ginkgo e2e tests or network-using test code were added, so IPv6/disconnected compatibility is not affected.
No-Weak-Crypto	✅ Passed	Scanned all 6 changed files; found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB usage or custom secret comparisons.
Container-Privileges	✅ Passed	No changed manifest introduces privileged settings; the diff only touches feature gates and CRD schemas, and searches found no privileged/hostNetwork/allowPrivilegeEscalation/root settings.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files are CRD/feature-gate manifests only; no log statements or sensitive-data patterns appeared in the modified files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@proietfb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	f73a676	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.