[release-4.22] AGENT-1544: Backport NoRegistryClusterInstall feature to release-4.22#2930
Conversation
- Created machineconfiguration/v1/types_internalreleaseimage.go with v1 API - Updated compatibility level from 4 (alpha) to 1 (stable/GA) - Registered InternalReleaseImage types in v1 scheme - Created v1 integration test suite - Updated payload CRD script to use v1 instead of v1alpha1 - Generated all CRD manifests, deepcopy, and swagger docs Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add manual CRD override to include v1alpha1 schema alongside v1 schema for InternalReleaseImage API. This allows both API versions to coexist during the graduation period, enabling gradual migration from v1alpha1 to v1 across dependent repositories. The manual override contains the complete v1alpha1 schema from the featuregated manifest, which will be merged with the v1 schema during code generation to produce a CRD that serves both versions. This addresses the review feedback to support both schemas simultaneously rather than requiring all consumers to update at once. Related: openshift#2880 (comment)
During code generation, the manifest-merge tool combines this override with the v1 schema generated from Go types to produce a final CRD that serves both versions: - v1 (storage: true): New stable API with MaxItems=5 for Conditions - v1alpha1 (storage: false): Original alpha API with MaxItems=20 for Conditions Both versions are served, but v1 is the storage version. Resources submitted via v1alpha1 are automatically converted to v1 for storage in etcd, then converted back to v1alpha1 when read, ensuring backward compatibility without requiring simultaneous updates across all consuming repositories.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request references AGENT-1500 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @pawanpinjarkar! Some important instructions when contributing to openshift/api: |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
size/XXL
|
/cc @andfasano @bfournie |
pawanpinjarkar
changed the title
|
/retitle [release-4.22] AGENT-1544: Backport NoRegistryClusterInstall feature to release-4.22 |
openshift-ci
Bot
changed the title
|
@pawanpinjarkar: This pull request references AGENT-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/test verify |
|
/assign @yuqi-zhang |
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@pawanpinjarkar: This pull request references AGENT-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
In 5.0 it was a bit safer since we were doing the switch on an unreleased version, but here in 4.22 I think we would need to be a bit more careful. Deferring to @JoelSpeed on what the best path forward is (this looks like it's directly switching the payload CRD, I guess that's fine since it won't be active until we GA the featuregate?) |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
|
@pawanpinjarkar: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
This patch is part of the NoRegistryClusterInstall feature backport to 4.22. It contains the following PR:
#2880