WIP: CONSOLE-5209: Promote IngressComponentRouteLabels to Default

[jhadvig]

Summary

Promote the IngressComponentRouteLabels feature gate from TechPreview/DevPreview to Default (GA).

This is a WIP PR for running /test verify-feature-promotion to validate that all promotion requirements are met per the feature-zero-to-hero guide.

Change

- enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
+ enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade(), inDefault()).

Promotion requirements

• At least 5 tests tagged [OCPFeatureGate:IngressComponentRouteLabels] — openshift/origin#31385
• Tests run at least 7 times per week across all platforms
• 95%+ pass rate
• Periodic jobs configured — openshift/release#81895
• 14 days before branch cut
• /test verify-feature-promotion passes

Dependencies

• API: openshift/api#2845 (merged) — Labels field on ComponentRouteSpec
• Operator: openshift/console-operator#1184 (in review) — label propagation
• Enhancement: openshift/enhancements#2033 (merged)

Jira

https://redhat.atlassian.net/browse/CONSOLE-5209

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jhadvig: This pull request references CONSOLE-5209 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Promote the IngressComponentRouteLabels feature gate from TechPreview/DevPreview to Default (GA).

This is a WIP PR for running /test verify-feature-promotion to validate that all promotion requirements are met per the feature-zero-to-hero guide.

Change

- enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
+ enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade(), inDefault()).

Promotion requirements

• At least 5 tests tagged [OCPFeatureGate:IngressComponentRouteLabels] — openshift/origin#31385
• Tests run at least 7 times per week across all platforms
• 95%+ pass rate
• Periodic jobs configured — openshift/release#81895
• 14 days before branch cut
• /test verify-feature-promotion passes

Dependencies

• API: openshift/api#2845 (merged) — Labels field on ComponentRouteSpec
• Operator: openshift/console-operator#1184 (in review) — label propagation
• Enhancement: openshift/enhancements#2033 (merged)

Jira

https://redhat.atlassian.net/browse/CONSOLE-5209

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @jhadvig! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 20f4605e-f383-4db8-b26e-8eecce0f4187

📥 Commits

Reviewing files that changed from the base of the PR and between c8f22a1 and edf277c.

📒 Files selected for processing (4)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• features/features.go

---

📝 Walkthrough

Walkthrough

FeatureGateIngressComponentRouteLabels now enables the feature in the default configuration, alongside the existing DevPreview and TechPreview configurations. The feature-gate documentation and Hypershift and SelfManagedHA default manifests reflect this change.

Suggested reviewers: joelspeed, everettraven

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: promoting IngressComponentRouteLabels to Default.
Description check	✅ Passed	The description is clearly related and matches the feature-gate promotion change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only changes feature-gate metadata and manifests; no Ginkgo tests or test titles were added or modified.
Test Structure And Quality	✅ Passed	No Ginkgo test files were changed in this PR; it only updates feature-gate metadata, so the test-structure review is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests were added; the PR only updates feature-gate metadata/manifests to enable IngressComponentRouteLabels by default.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes feature-gate config/docs/manifests; no *_test.go or Ginkgo specs were added, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only feature-gate metadata changed; no deployment manifests, controllers, or pod scheduling settings were modified.
Ote Binary Stdout Contract	✅ Passed	PR only changes feature-gate config/docs; no main/init/TestMain/suite stdout writes were added in changed code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only updates feature-gate metadata/manifests, so IPv4/disconnected compatibility is not implicated.
No-Weak-Crypto	✅ Passed	Diff only promotes a feature gate and updates manifests/docs; no weak-crypto patterns, custom crypto, or secret/token comparisons were found.
Container-Privileges	✅ Passed	Diff only updates feature-gate enablement/docs; no touched manifest contains privileged:true, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs	✅ Passed	HEAD only changes feature-gate enablement and manifests; no log statements or sensitive-data strings appear in the diff or touched files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	edf277c	link	true	/test verify-feature-promotion
ci/prow/verify	edf277c	link	true	/test verify
ci/prow/unit	edf277c	link	true	/test unit
ci/prow/integration	edf277c	link	true	/test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.