Skip to content

OCPBUGS-84391: Bump go-jose to v4.1.4#2170

Open
jkaurredhat wants to merge 1 commit into
openshift:release-4.22from
jkaurredhat:update-go-jose-4.22
Open

OCPBUGS-84391: Bump go-jose to v4.1.4#2170
jkaurredhat wants to merge 1 commit into
openshift:release-4.22from
jkaurredhat:update-go-jose-4.22

Conversation

@jkaurredhat
Copy link
Copy Markdown
Contributor

@jkaurredhat jkaurredhat commented Jun 1, 2026

Summary

Update github.com/go-jose/go-jose/v4 from v4.1.3 to v4.1.4 to address CVE-2026-34986.

CVE Details

  • CVE-2026-34986: Go JOSE Denial of Service via crafted JSON Web Encryption (JWE) object
  • GHSA: GHSA-7ww6-75fj-jcj7
  • Component: JSON Web Encryption (JWE) decryption
  • Patched version: v4.1.4

Vulnerability Description

Decrypting a JSON Web Encryption (JWE) object will panic if the alg field indicates a key wrapping algorithm (one ending in KW) and the encrypted_key field is empty. The panic happens when cipher.KeyUnwrap() attempts to allocate a slice with a zero or negative length based on the length of the encrypted_key.

Changes

  • Bump github.com/go-jose/go-jose/v4 from v4.1.3 to v4.1.4
  • Update vendor/ directory

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jkaurredhat: This pull request references Jira Issue OCPBUGS-84391, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-84391 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Update github.com/go-jose/go-jose/v4 from v4.1.3 to v4.1.4 to address CVE-2026-34986.

CVE Details

  • CVE-2026-34986: Go JOSE Denial of Service via crafted JSON Web Encryption (JWE) object
  • GHSA: GHSA-7ww6-75fj-jcj7
  • Component: JSON Web Encryption (JWE) decryption
  • Patched version: v4.1.4

Vulnerability Description

Decrypting a JSON Web Encryption (JWE) object will panic if the alg field indicates a key wrapping algorithm (one ending in KW) and the encrypted_key field is empty. The panic happens when cipher.KeyUnwrap() attempts to allocate a slice with a zero or negative length based on the length of the encrypted_key.

Changes

  • Bump github.com/go-jose/go-jose/v4 from v4.1.3 to v4.1.4
  • Update vendor/ directory

Test Plan

  • Build succeeds
  • Existing tests pass
  • No functional changes (dependency update only)

Related: OCPBUGS-84391

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 115b1431-ea65-42e2-adfa-e8ce95b2eadf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 1, 2026
@openshift-ci openshift-ci Bot requested review from CrystalChun and yoavsc0302 June 1, 2026 17:13
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkaurredhat
Once this PR has been reviewed and has the lgtm label, please assign danmanor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Update github.com/go-jose/go-jose/v4 from v4.1.3 to v4.1.4 to address
CVE-2026-34986 (Go JOSE DoS via crafted JWE object).

The assisted-installer is OpenShift-specific infrastructure with no
upstream equivalent, so this is an OpenShift-only patch.

Related: OCPBUGS-84391
@jkaurredhat jkaurredhat force-pushed the update-go-jose-4.22 branch from ea34e01 to 0e36396 Compare June 1, 2026 17:47
@jkaurredhat
Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

@jkaurredhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants