Skip to content

WIP: DPTP-2938: add configurable skip for authoritative decrease by workload type#5307

Open
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:pod-scaler-adaptive-authoritative-decrease
Open

WIP: DPTP-2938: add configurable skip for authoritative decrease by workload type#5307
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:pod-scaler-adaptive-authoritative-decrease

Conversation

@deepsm007

@deepsm007 deepsm007 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Follow-up to DPTP-2938 / peak usage basis (#5306, merged). Adds configurable skip rules so authoritative resource decreases can be disabled for specific workload types or classes.

After authoritative rollout, image builds (OpenShift Build pods) were still at risk: peak basis fixes most burst cases, but limit decreases on build workloads remain a safety concern for compile spikes. This change lets ops skip authoritative decreases selectively without turning off authoritative mode globally.

openshift/release#81763

/cc @openshift/test-platform

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci openshift-ci Bot requested a review from a team July 10, 2026 19:51
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@deepsm007: This pull request references DPTP-2938 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Follow-up to DPTP-2938 / peak usage basis (#5306, merged). Adds configurable skip rules so authoritative resource decreases can be disabled for specific workload types or classes.

After authoritative rollout, image builds (OpenShift Build pods) were still at risk: peak basis fixes most burst cases, but limit decreases on build workloads remain a safety concern for compile spikes. This change lets ops skip authoritative decreases selectively without turning off authoritative mode globally.

/cc @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 584e1a96-c38e-49b7-a7c7-021d470cde4d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@deepsm007 deepsm007 force-pushed the pod-scaler-adaptive-authoritative-decrease branch from 0e2df30 to dd8eb2c Compare July 10, 2026 20:13
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration dd8eb2c link true /test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants