WIP: OCPBUGS-65896: Update library-go to remove Progressing on scaling#843
WIP: OCPBUGS-65896: Update library-go to remove Progressing on scaling#843tchap wants to merge 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
do-not-merge/hold
|
@tchap: This pull request references Jira Issue OCPBUGS-65896, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ksiddiqu@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughUpdates OpenShift module versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/retest |
tchap
force-pushed
the
no-progression-on-cluster-scaleup
branch
from
0fb4392 to
c8b8deb
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
tchap
force-pushed
the
no-progression-on-cluster-scaleup
branch
2 times, most recently
from
8a3beca to
b2426e5
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 136-137: The replace directive currently pointing to the personal
fork "github.com/tchap/library-go" must be removed and replaced with the
official upstream module; delete the replace line `replace
github.com/openshift/library-go => github.com/tchap/library-go v0.0.0-...` and
update the canonical require for `github.com/openshift/library-go` to the
pseudo-version or release that contains the merged openshift/library-go#2128
commit (preserve the `// branch: workload-condition-overwrites` note in your
commit message rather than in go.mod), then run `go mod tidy` to refresh go.sum
and ensure no remaining references to the fork remain.
ℹ️ Review info
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (10)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/apps/deployment/status.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/apiserver/controller/workload/workload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/crypto/keys.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptionconfig/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (10)
bindata/oauth-apiserver/deploy.yamlbindata/oauth-openshift/deployment.yamlgo.modpkg/operator/workload/testdata/sync_ds_scenario_1.yamlpkg/operator/workload/testdata/sync_ds_scenario_2.yamlpkg/operator/workload/testdata/sync_ds_scenario_3.yamltest-data/apply-configuration/overall/oauth-apiserver-creation-minimal/expected-output/Management/ApplyStatus/cluster-scoped-resources/operator.openshift.io/authentications/c5b3-body-cluster.yamltest-data/apply-configuration/overall/oauth-apiserver-creation-minimal/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/apps/deployments/7350-body-apiserver.yamltest-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/ApplyStatus/cluster-scoped-resources/operator.openshift.io/authentications/5749-body-cluster.yamltest-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/Create/namespaces/openshift-authentication/apps/deployments/a3d6-body-oauth-openshift.yaml
| // branch: workload-condition-overwrites | ||
| replace github.com/openshift/library-go => github.com/tchap/library-go v0.0.0-20260218224355-0b782a2d1e90 |
There was a problem hiding this comment.
Replace directive points to a personal fork — must be swapped for the official upstream before merging.
github.com/tchap/library-go is a personal fork. Once openshift/library-go#2128 merges and a proper release/pseudo-version is cut for github.com/openshift/library-go, this replace directive (and its corresponding go.sum entries) must be removed and the canonical require version on line 15 updated to point at the merged commit.
The // branch: workload-condition-overwrites comment is a useful breadcrumb — consider preserving it in the commit message rather than in go.mod itself.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 136 - 137, The replace directive currently pointing to
the personal fork "github.com/tchap/library-go" must be removed and replaced
with the official upstream module; delete the replace line `replace
github.com/openshift/library-go => github.com/tchap/library-go v0.0.0-...` and
update the canonical require for `github.com/openshift/library-go` to the
pseudo-version or release that contains the merged openshift/library-go#2128
commit (preserve the `// branch: workload-condition-overwrites` note in your
commit message rather than in go.mod), then run `go mod tidy` to refresh go.sum
and ensure no remaining references to the fork remain.
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The workload package in library-go is now improved to handle status conditions properly.
tchap
force-pushed
the
no-progression-on-cluster-scaleup
branch
from
b2426e5 to
f7e5f4e
Compare
openshift-ci
bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchap The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@tchap: This pull request references Jira Issue OCPBUGS-65896, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ksiddiqu@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
136-137:⚠️ Potential issue | 🟠 MajorPersonal fork replace must not ship in final merge branch.
At Line 137,
github.com/openshift/library-gois still redirected to a personal fork. This is fine for WIP testing, but it remains a merge blocker until replaced with the canonical upstream module version containing the needed fix.#!/bin/bash # Verify whether personal fork references still exist in module files. # Expected before merge: no matches for github.com/tchap/library-go. set -euo pipefail echo "== go.mod references ==" rg -n 'github\.com/tchap/library-go|replace\s+github\.com/openshift/library-go' go.mod echo echo "== go.sum references ==" if [ -f go.sum ]; then rg -n 'github\.com/tchap/library-go' go.sum || true else echo "go.sum not present" fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 136 - 137, The go.mod contains a replace directive redirecting github.com/openshift/library-go to a personal fork ("replace github.com/openshift/library-go => github.com/tchap/library-go v0.0.0-20260414082126-08c8c154ce03"); remove or replace that line with the canonical upstream module version (or delete the replace and set the correct upstream version in the require section), then run go mod tidy to update go.sum and confirm no remaining references to github.com/tchap/library-go; ensure the final commit contains only the official upstream module reference for github.com/openshift/library-go.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Around line 136-137: The go.mod contains a replace directive redirecting
github.com/openshift/library-go to a personal fork ("replace
github.com/openshift/library-go => github.com/tchap/library-go
v0.0.0-20260414082126-08c8c154ce03"); remove or replace that line with the
canonical upstream module version (or delete the replace and set the correct
upstream version in the require section), then run go mod tidy to update go.sum
and confirm no remaining references to github.com/tchap/library-go; ensure the
final commit contains only the official upstream module reference for
github.com/openshift/library-go.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e66d7000-3c58-4319-a856-ac540d01341c
⛔ Files ignored due to path filters (3)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/api/.coderabbit.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/Makefileis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
|
/retest-required |
openshift-ci-robot
added
jira/invalid-bug
|
@tchap: This pull request references Jira Issue OCPBUGS-65896, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tchap: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is currently only open to test openshift/library-go#2128
/hold
Summary by CodeRabbit