OCPBUGS-98572: Tolerate unknown template fields during payload loading

[jhadvig]

Summary

• Make template rendering errors non-fatal during LoadUpdate
• When the CVO encounters a manifest with unknown template fields, skip it with a warning instead of failing the entire payload load

Why

Backport of the tolerance logic from PR #1410 (5.0). Without this, 4.22→5.0 major upgrades are blocked: the 4.22 CVO tries to render 5.0 manifests that use {{index .Images "..."}}, fails because .Images doesn't exist in the 4.22 manifestRenderConfig, and sets ReleaseAccepted=False.

With this fix, the 4.22 CVO skips unrenderable manifests with a warning. The new 5.0 CVO re-loads the full payload after it replaces the old one at run-level 0, correctly rendering all manifests.

This was one of two issues that caused the revert of CVO#1398 and blocked 5.0 nightly payloads for 69+ hours (TRT-2776).

Test plan

• New unit test TestLoadUpdateSkipsUnknownTemplateFields verifies manifests with unknown template fields are skipped while valid manifests are loaded
• CI passes

🤖 Generated with Claude Code

[openshift-ci-robot]

@jhadvig: This pull request references OTA-2064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Make template rendering errors non-fatal during LoadUpdate
• When the CVO encounters a manifest with unknown template fields, skip it with a warning instead of failing the entire payload load

Why

Backport of the tolerance logic from PR #1410 (5.0). Without this, 4.22→5.0 major upgrades are blocked: the 4.22 CVO tries to render 5.0 manifests that use {{index .Images "..."}}, fails because .Images doesn't exist in the 4.22 manifestRenderConfig, and sets ReleaseAccepted=False.

With this fix, the 4.22 CVO skips unrenderable manifests with a warning. The new 5.0 CVO re-loads the full payload after it replaces the old one at run-level 0, correctly rendering all manifests.

This was one of two issues that caused the revert of CVO#1398 and blocked 5.0 nightly payloads for 69+ hours (TRT-2776).

Test plan

• New unit test TestLoadUpdateSkipsUnknownTemplateFields verifies manifests with unknown template fields are skipped while valid manifests are loaded
• CI passes

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: adb9f24a-dd15-42f5-ba19-74eb661ddcfc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

/label backport-risk-assessed

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-98572, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-98572 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Make template rendering errors non-fatal during LoadUpdate
• When the CVO encounters a manifest with unknown template fields, skip it with a warning instead of failing the entire payload load

Why

Backport of the tolerance logic from PR #1410 (5.0). Without this, 4.22→5.0 major upgrades are blocked: the 4.22 CVO tries to render 5.0 manifests that use {{index .Images "..."}}, fails because .Images doesn't exist in the 4.22 manifestRenderConfig, and sets ReleaseAccepted=False.

With this fix, the 4.22 CVO skips unrenderable manifests with a warning. The new 5.0 CVO re-loads the full payload after it replaces the old one at run-level 0, correctly rendering all manifests.

This was one of two issues that caused the revert of CVO#1398 and blocked 5.0 nightly payloads for 69+ hours (TRT-2776).

Test plan

• New unit test TestLoadUpdateSkipsUnknownTemplateFields verifies manifests with unknown template fields are skipped while valid manifests are loaded
• CI passes

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

/jira refresh

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-98572, which is invalid:

• expected dependent Jira Issue OCPBUGS-98573 to target a version in 5.0.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

/jira refresh
/verified by CI

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-98572, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-98573 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-98573 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

Details

In response to this:

/jira refresh
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jhadvig: This PR has been marked as verified by CI.

Details

In response to this:

/jira refresh
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jhadvig: Jira Issue Verification Checks: Jira Issue OCPBUGS-98572
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-98572 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

• Make template rendering errors non-fatal during LoadUpdate
• When the CVO encounters a manifest with unknown template fields, skip it with a warning instead of failing the entire payload load

Why

Backport of the tolerance logic from PR #1410 (5.0). Without this, 4.22→5.0 major upgrades are blocked: the 4.22 CVO tries to render 5.0 manifests that use {{index .Images "..."}}, fails because .Images doesn't exist in the 4.22 manifestRenderConfig, and sets ReleaseAccepted=False.

With this fix, the 4.22 CVO skips unrenderable manifests with a warning. The new 5.0 CVO re-loads the full payload after it replaces the old one at run-level 0, correctly rendering all manifests.

This was one of two issues that caused the revert of CVO#1398 and blocked 5.0 nightly payloads for 69+ hours (TRT-2776).

Test plan

• New unit test TestLoadUpdateSkipsUnknownTemplateFields verifies manifests with unknown template fields are skipped while valid manifests are loaded
• CI passes

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in release 4.22.0-0.nightly-2026-07-14-080922