[release-4.22] OCPBUGS-97828, OCPBUGS-97829: Stabilize telemetry config to prevent continuous console pod rollouts#1183
Conversation
…le pod rollouts Remove early return in GetTelemetryConfiguration() so the function always produces the same key set regardless of telemeter-client availability. Make GetAccessToken errors non-fatal for disconnected clusters. Add key set stability tests. Assisted by: Claude (Opus 4.6)
…is absent
Return ("", nil) instead of a hard error when cloud.openshift.com is
missing from the pull-secret. This is expected on disconnected clusters
and should not degrade the console operator.
Also replaces fmt.Println with klog.Errorf for JSON parse errors.
Co-authored-by: Santiago Greco <fsgreco@redhat.com>
Assisted-by: Claude (Opus 4.6)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-90370 has been cloned as Jira Issue OCPBUGS-97828. Will retitle bug to link to clone. Jira Issue OCPBUGS-87348 has been cloned as Jira Issue OCPBUGS-97829. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-97828, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-97829, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@sg00dwin: This pull request references Jira Issue OCPBUGS-97828, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-97829, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@sg00dwin: This pull request references Jira Issue OCPBUGS-97828, which is valid. 7 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-97829, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @jhadvig |
This is an automated cherry-pick of #1173
/assign sg00dwin