AGENT-1522: bump InternalReleaseImage to v1 by pawanpinjarkar · Pull Request #10620 · openshift/installer

pawanpinjarkar · 2026-06-11T19:28:53Z

Chores
- Updated module dependency configuration to use an alternate source for API dependencies.
```
go get github.com/openshift/api
go mod tidy
go mod vendor
```

openshift-ci-robot · 2026-06-11T19:29:47Z

@pawanpinjarkar: This pull request references AGENT-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-11T19:31:09Z

📝 Walkthrough

Walkthrough

A replace directive is added to go.mod, redirecting the github.com/openshift/api module to a custom fork at github.com/pawanpinjarkar/api with a pinned version identifier.

Changes

Module replacement

Layer / File(s)	Summary
Module replacement directive `go.mod`	Add a `replace` directive that redirects `github.com/openshift/api` imports to `github.com/pawanpinjarkar/api` at a pinned version for all builds using this go.mod.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references bumping InternalReleaseImage to v1, but the actual change is a go.mod replace directive redirecting github.com/openshift/api to a fork, which doesn't match the stated objective.	Update the title to accurately reflect the change: something like 'Replace openshift/api with pawanpinjarkar/api fork' or clarify how this redirect supports the InternalReleaseImage bump.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR adds 184 new test files to the repository, but ZERO of them use Ginkgo testing framework. All test files use standard Go testing (via `func Test...` and `t.Run()`), so the Ginkgo test namin...
Test Structure And Quality	✅ Passed	PR `#10620` changes only go.mod/go.sum (replace directive for openshift/api); no Ginkgo test code (It blocks) was modified, so the test-quality checks are not applicable.
Microshift Test Compatibility	✅ Passed	PR commit only updates go.mod (replace openshift/api -> pawanpinjarkar/api). Among changed non-vendor *_test.go files, none contain “ginkgo” or ginkgo/v2—no MicroShift-incompatible Ginkgo e2e tests...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Checked PR HEAD changed non-vendor _test.go/.go for any github.com/onsi/ginkgo or ginkgo. usage: none found, so no new SNO-incompatible multi-node Ginkgo e2e tests were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	PR 10620 only updates go.mod (replace github.com/openshift/api) and related go.sum/vendor API files; no installer manifests/operator/controller scheduling constraints were changed.
Ote Binary Stdout Contract	✅ Passed	PR only updates go.mod/go.sum (replace) and vendored openshift/api; representative changed vendor Go files contain no fmt/klog Print/Println/Printf, so no main/suite process-level stdout writes wer...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR diff vs origin/main includes only go.mod/go.sum, images/installer/Dockerfile.ci, and vendored api changes—no new or modified *_test.go/Ginkgo e2e specs, so no IPv4/Internet assumptions to flag.
No-Weak-Crypto	✅ Passed	PR appears limited to go.mod/go.sum replace + regenerated openshift/api vendored files; searches of updated vendor code found no md5/sha1/DES/RC4/3DES/Blowfish/ECB usages.
Container-Privileges	✅ Passed	PR `#10620` modifies only go.mod and go.sum (no container/K8s manifest diffs). No instances of hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation: true found in related YAML under vendor...
No-Sensitive-Data-In-Logs	✅ Passed	PR `#10620` changes only go.mod (adds a replace for github.com/openshift/api) and go.sum hashes; no application/logging code touched, so no sensitive data logging introduced.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

pawanpinjarkar · 2026-06-11T19:32:30Z

/cc @andfasano @sadasu @bfournie

pawanpinjarkar · 2026-06-11T19:36:11Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

openshift-ci · 2026-06-11T19:54:23Z

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

pawanpinjarkar · 2026-06-11T20:09:03Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

openshift-ci · 2026-06-11T20:09:06Z

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

pawanpinjarkar · 2026-06-11T22:12:11Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

openshift-ci · 2026-06-11T22:12:14Z

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

sadasu · 2026-06-12T00:59:57Z

/testwith openshift/installer/main/e2e-agent-compact-ipv4-iso-no-registry openshift/api#2880 openshift/client-go#383

sadasu · 2026-06-12T01:03:05Z

/retitle WIP: AGENT-1522: bump InternalReleaseImage to v1

The go.mod changes point to Pawan's openshift/api commit.

Also, @pawanpinjarkar while making the next update to the PR, please make sure to put just the go.mod changes in 1 commit and everything else in a 2nd commit.

openshift-ci · 2026-06-12T10:09:31Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9993180-6646-11f1-9b81-8f288bc688c1-0

openshift-ci · 2026-06-12T12:51:55Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79d770f0-665d-11f1-9ef4-6c006290fce7-0

openshift-ci · 2026-06-15T15:33:05Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79d6df40-68cf-11f1-9a39-3d80b7114f29-0

sadasu · 2026-06-15T20:23:13Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal/dev-scripts#1912

openshift-ci · 2026-06-15T20:23:18Z

@sadasu: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message.


unable to get pr from github for: openshift-metal/dev-scripts#1912: Get "http://ghproxy/repos/openshift-metal/dev-scripts/pulls/1912": failed to get installation id for org openshift-metal: the github app is not installed in organization openshift-metal

Please contact an administrator to resolve this issue.

sadasu · 2026-06-15T20:24:32Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal3/dev-scripts#1912

openshift-ci · 2026-06-15T20:24:35Z

@sadasu: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

openshift-ci · 2026-06-25T15:17:30Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f474fbc0-70a8-11f1-8667-ca570bd96a96-0

openshift-ci · 2026-06-25T16:34:13Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ac7a0210-70b3-11f1-9ff0-58eea2434dcb-0

openshift-ci · 2026-06-26T08:31:49Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6110c6c0-7139-11f1-9201-ebaca0b9eef9-0

openshift-ci · 2026-06-26T12:35:28Z

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7ad1f9e0-715b-11f1-9fd6-756025c45f8c-0

bfournie · 2026-06-26T14:43:06Z

Unit test is failing, perhaps needs a rebase?
```

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -22,5 +22,4 @@
        	            	   DeletionGracePeriodSeconds: (*int64)(<nil>),
        	            	-  Labels: (map[string]string) (len=2) {
        	            	-   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) "",
        	            	-   (string) (len=42) "machineconfiguration.openshift.io/osstream": (string) (len=7) "rhel-10"
        	            	+  Labels: (map[string]string) (len=1) {
        	            	+   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) ""
        	            	   },
        	Test:       	Test_GenerateMachines/usertags
    gcpmachines_test.go:112: 
        	Error Trace:	/go/src/github.com/openshift/installer/pkg/asset/machines/gcp/gcpmachines_test.go:112

bfournie · 2026-06-28T12:46:21Z

Looks like a unit test failure with OSStream expecting the rhel-10 label. I wonder why the vendor/github.com/openshift/api/features/features.go changed, as that may be what is causing this.

         	            	Diff:
           	            	--- Expected
           	            	+++ Actual
           	            	@@ -22,5 +22,4 @@
           	            	   DeletionGracePeriodSeconds: (*int64)(<nil>),
           	            	-  Labels: (map[string]string) (len=2) {
           	            	-   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) "",
           	            	-   (string) (len=42) "machineconfiguration.openshift.io/osstream": (string) (len=7) "rhel-10"
           	            	+  Labels: (map[string]string) (len=1) {
           	            	+   (string) (len=30) "cluster.x-k8s.io/control-plane": (string) ""

andfasano · 2026-06-29T06:48:26Z

 	sigs.k8s.io/cluster-api-provider-azure => github.com/mboersma/cluster-api-provider-azure v0.3.1-0.20251030205607-3161b9cc8d3e
 )
+
+replace github.com/openshift/api => github.com/pawanpinjarkar/api v0.0.0-20260611132132-df7836b66b8f


The FeatureGateAWSClusterHostedDNSInstall feature gate was promoted to General Availability (GA) in openshift/api on June 11, 2026 (commit 564b1995796e). This promotion changed the feature from requiring TechPreviewNoUpgrade or CustomNoUpgrade feature sets to being enabled by default in all feature sets. The openshift/api dependency update required for AGENT-1522 (graduating InternalReleaseImage from v1alpha1 to v1) pulls in this GA promotion, since InternalReleaseImage v1 was added on June 26, 2026 - after the AWSClusterHostedDNSInstall promotion. This commit updates the feature gate validation test to reflect that AWS UserProvisionedDNS is now allowed in the Default feature set without requiring explicit feature gate enablement.

andfasano · 2026-07-07T08:16:52Z

/lgtm

andfasano · 2026-07-07T08:29:19Z

                items:
                  description: ClusterVersionCapability enumerates optional, core
                    cluster components.
-                  enum:


out of curiosity, what triggered this change?

When updating github.com/openshift/api, the install-config CRD must be regenerated. This is documented in AGENTS.md The upstream https://github.com/openshift/installer/pull/10620/changes#diff-b318e1e6bbcc59892bb6b4298564b051c6f6d5d848878d14aab856509ff0625cL1310 changed how ClusterVersionCapability is defined in the CRD schema.
Without this change, the make verify was failing

sadasu · 2026-07-07T14:07:00Z

/test

sadasu · 2026-07-07T14:07:59Z

/test e2e-aws-custom-dns-techpreview

sadasu · 2026-07-07T14:08:19Z

/test e2e-aws-ovn-dualstack-ipv6-primary-techpreview

pawanpinjarkar · 2026-07-07T17:45:46Z

/hold
as api version upgrade is not directly impacting installer for IRI resource

openshift-ci · 2026-07-07T18:48:43Z

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-dualstack-ipv6-primary-techpreview	`e48435f`	link	false	`/test e2e-aws-ovn-dualstack-ipv6-primary-techpreview`
ci/prow/e2e-aws-custom-dns-techpreview	`e48435f`	link	false	`/test e2e-aws-custom-dns-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sadasu · 2026-07-10T17:10:45Z

/close

Not necessary at this time.

openshift-ci · 2026-07-10T17:10:56Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-07-10T17:11:05Z

@sadasu: Closed this PR.

Details

In response to this:

/close

Not necessary at this time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2026

openshift-ci Bot requested review from andfasano and bfournie June 11, 2026 19:30

openshift-ci Bot requested a review from sadasu June 11, 2026 19:35

openshift-ci Bot changed the title ~~AGENT-1522: bump InternalReleaseImage to v1~~ WIP: AGENT-1522: bump InternalReleaseImage to v1 Jun 12, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026

andfasano mentioned this pull request Jun 12, 2026

AGENT-1522: Graduate InternalReleaseImage from v1alpha1 to v1 openshift/api#2880

Merged

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2026

pawanpinjarkar force-pushed the promote-iri-api-2-v1 branch from 2c81db2 to 04689cc Compare June 15, 2026 16:00

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2026

pawanpinjarkar changed the title ~~WIP: AGENT-1522: bump InternalReleaseImage to v1~~ AGENT-1522: bump InternalReleaseImage to v1 Jun 15, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2026

pawanpinjarkar force-pushed the promote-iri-api-2-v1 branch from e03a87f to 6d24aab Compare June 26, 2026 19:17

andfasano reviewed Jun 29, 2026

View reviewed changes

pawanpinjarkar force-pushed the promote-iri-api-2-v1 branch from 6d24aab to 00075be Compare June 29, 2026 14:17

pawanpinjarkar added 2 commits July 6, 2026 09:37

AGENT-1522: bump InternalReleaseImage to v1

db8229e

go mod vendor

2812330

pawanpinjarkar force-pushed the promote-iri-api-2-v1 branch from 00075be to 2812330 Compare July 6, 2026 13:38

pawanpinjarkar force-pushed the promote-iri-api-2-v1 branch from fc24d7d to 641b89f Compare July 6, 2026 15:20

regenerate install-config CRD after openshift/api bump

e48435f

openshift-ci Bot assigned andfasano Jul 7, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026

andfasano reviewed Jul 7, 2026

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2026

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026

openshift-ci Bot closed this Jul 10, 2026

Uh oh!

Conversation

pawanpinjarkar commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

pawanpinjarkar commented Jun 11, 2026

Uh oh!

pawanpinjarkar commented Jun 11, 2026

Uh oh!

openshift-ci Bot commented Jun 11, 2026

Uh oh!

pawanpinjarkar commented Jun 11, 2026

Uh oh!

openshift-ci Bot commented Jun 11, 2026

Uh oh!

pawanpinjarkar commented Jun 11, 2026

Uh oh!

openshift-ci Bot commented Jun 11, 2026

Uh oh!

sadasu commented Jun 12, 2026

Uh oh!

sadasu commented Jun 12, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 12, 2026

Uh oh!

openshift-ci Bot commented Jun 12, 2026

Uh oh!

openshift-ci Bot commented Jun 15, 2026

Uh oh!

sadasu commented Jun 15, 2026

Uh oh!

openshift-ci Bot commented Jun 15, 2026

Uh oh!

sadasu commented Jun 15, 2026

Uh oh!

openshift-ci Bot commented Jun 15, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 25, 2026

Uh oh!

openshift-ci Bot commented Jun 26, 2026

Uh oh!

openshift-ci Bot commented Jun 26, 2026

Uh oh!

bfournie commented Jun 26, 2026

Uh oh!

bfournie commented Jun 28, 2026

Uh oh!

andfasano Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

andfasano commented Jul 7, 2026

Uh oh!

andfasano Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

pawanpinjarkar Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

sadasu commented Jul 7, 2026

Uh oh!

sadasu commented Jul 7, 2026

Uh oh!

sadasu commented Jul 7, 2026

Uh oh!

pawanpinjarkar commented Jul 7, 2026

Uh oh!

openshift-ci Bot commented Jul 7, 2026

pawanpinjarkar commented Jun 11, 2026 •

edited

Loading

openshift-ci-robot commented Jun 11, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

sadasu commented Jun 12, 2026 •

edited by openshift-ci Bot

Loading