[release-4.20] Backport ocl test fixes and shard the test suite#6305
[release-4.20] Backport ocl test fixes and shard the test suite#6305umohnani8 wants to merge 5 commits into
Conversation
Replace the monolithic test/e2e-ocl/ directory with a sharded layout matching the structure on release-4.21 and later: - test/e2e-ocl-shared/: Common helpers and Containerfiles used by both shards - test/e2e-ocl-1of2/: First shard (8 tests: layering, rollout, rebuild, entitled, etc.) - test/e2e-ocl-2of2/: Second shard (8 tests: OKD, failure recovery, deletion, etc.) Stabilization fixes included: - CleanupEphemeralBuildObjects: owners-before-dependents deletion ordering with per-resource 3-minute timeout and 5s poll interval - StreamContainerLogToFile: non-fatal with 5s retry sleep - waitForJobToReachCondition: timeout bumped from 10m to 20m - imagepruner: dual-flag handling for Docker.io/GitHub registry error variance - Non-fatal log streaming throughout test helpers Tests excluded from backport (new features not on 4.20): - TestCurrentMachineOSBuildAnnotationHandling - TestLayeredImageServingDuringNodeScaleUp - TestStaleAnnotationClearedOnLayerOnlyChange Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Urvashi <umohnani@redhat.com>
Add metav1.IsControlledBy guard before deleting MachineOSBuilds during MachineOSConfig deletion. Without this check, if a MOSC is deleted and recreated with the same name but a different UID, the controller could incorrectly delete MOSBs belonging to the new MOSC. Signed-off-by: Urvashi <umohnani@redhat.com>
When polling for MachineOSBuild conditions, a transient NotFound error can occur if the object is briefly absent (e.g., during recreation). Return false instead of erroring out so the poll continues retrying. Signed-off-by: Urvashi <umohnani@redhat.com>
When a build job already exists (AlreadyExists on create), the MOSB was not being annotated with the job's UID. This caused getJobForMOSB to spin indefinitely waiting for an annotation that never appeared on the reuse path. Now fetch the existing job and annotate the MOSB before returning. Signed-off-by: Urvashi <umohnani@redhat.com>
Remove the skopeo-install script used for the OCL test suite as it has now been added as part of the CI config in openshift/release. Cherry-pick of openshift#6202 Signed-off-by: Urvashi <umohnani@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Backport test fixes for the OCL test suite.
Shard the OCL test suite into 2 parts.
Remove the skopeo-install script.