Skip to content

OCPBUGS-41605: Retain namespace selection between network policies tabs#422

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
pcbailey:bug-fix/41605
Jun 1, 2026
Merged

OCPBUGS-41605: Retain namespace selection between network policies tabs#422
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
pcbailey:bug-fix/41605

Conversation

@pcbailey
Copy link
Copy Markdown
Contributor

@pcbailey pcbailey commented Jun 1, 2026

This PR fixes a bug where a namespace selected on the networkPolicies tab of the NetworkPolicies page would be reset if the user navigates to the MultiNetworkPolicies tab while MultiNetworkPolicies are disabled and then navigates back to the NetworkPolicies page.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-41605

Demo

retain-namespace-selection-networkPolicies--2026-06-01-08-18-30.mp4

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@pcbailey: This pull request references Jira Issue OCPBUGS-41605, which is invalid:

  • expected Jira Issue OCPBUGS-41605 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR fixes a bug where a namespace selected on the networkPolicies tab of the NetworkPolicies page would be reset if the user navigates to the MultiNetworkPolicies tab while MultiNetworkPolicies are disabled and then navigates back to the NetworkPolicies page.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-41605

Demo

retain-namespace-selection-networkPolicies--2026-06-01-08-18-30.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c0d0c846-f6bc-4745-a643-e079b43a8e61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from upalatucci and vojtechszocs June 1, 2026 12:26
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@pcbailey pcbailey added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

@pcbailey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 16b0e96 into openshift:release-4.19 Jun 1, 2026
5 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@pcbailey: Jira Issue OCPBUGS-41605: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41605 has been moved to the MODIFIED state.

Details

In response to this:

This PR fixes a bug where a namespace selected on the networkPolicies tab of the NetworkPolicies page would be reset if the user navigates to the MultiNetworkPolicies tab while MultiNetworkPolicies are disabled and then navigates back to the NetworkPolicies page.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-41605

Demo

retain-namespace-selection-networkPolicies--2026-06-01-08-18-30.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey
Copy link
Copy Markdown
Contributor Author

pcbailey commented Jun 1, 2026

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pcbailey: new pull request created: #424

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in release 4.19.0-0.nightly-2026-06-02-144815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants