Skip to content

Backport cli download 1.4#2291

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-1.4from
NicholasYancey:backport-cli-download-1.4
Jul 9, 2026
Merged

Backport cli download 1.4#2291
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-1.4from
NicholasYancey:backport-cli-download-1.4

Conversation

@NicholasYancey

@NicholasYancey NicholasYancey commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Why the changes were made

OADP 1.6 added Console CLI download support in #1997: the operator deploys an oadp-cli download server and registers a ConsoleCLIDownload so users can install the CLI from Help → Command line tools in the OpenShift Console.
This PR backports the Console CLI download flow to oadp-1.4, with 1.4-specific adjustments:

  • RELATED_IMAGE_CONSOLE_CLI_DOWNLOAD points at quay.io/konveyor/oadp-cli-binaries:oadp-1.4.
  • OADP-7868: skip CLI download setup when the ConsoleCLIDownload CRD is not installed (e.g. clusters without Console capability).
  • Adapted from internal/controller/ package path (1.5/1.6) to controllers/ for 1.4 compatibility.
  • VMDP / file-restore download from later 1.6 commits is not included — CLI download only.

How to test the changes made

git checkout backport-cli-download-1.5
make test

Covers unit tests: console_test.go, vet, lint, bundle generation, and go mod verify.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e46f1931-767a-4c5b-9082-53643d22d76f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from eemcmullan and kaovilai July 7, 2026 19:16
@codecov-commenter

codecov-commenter commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.09598% with 313 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.62%. Comparing base (dbc2eda) to head (21c07a6).

⚠️ Current head 21c07a6 differs from pull request most recent head ea03ea8

Please upload reports for the commit ea03ea8 to get more accurate results.

Files with missing lines Patch % Lines
controllers/cli_download_controller.go 0.00% 294 Missing ⚠️
main.go 0.00% 18 Missing ⚠️
controllers/console.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           oadp-1.4    #2291      +/-   ##
============================================
- Coverage     34.72%   32.62%   -2.11%     
============================================
  Files            28       30       +2     
  Lines          4538     4861     +323     
============================================
+ Hits           1576     1586      +10     
- Misses         2787     3100     +313     
  Partials        175      175              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NicholasYancey NicholasYancey changed the title Backport cli download 1.5 Backport cli download 1.4 Jul 8, 2026
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@NicholasYancey

Copy link
Copy Markdown
Contributor Author

/retest-required

@NicholasYancey NicholasYancey self-assigned this Jul 9, 2026
@sseago

sseago commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, NicholasYancey, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

@NicholasYancey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c695230 into openshift:oadp-1.4 Jul 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants