Backport cli download 1.4#2291
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Please upload reports for the commit ea03ea8 to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## oadp-1.4 #2291 +/- ##
============================================
- Coverage 34.72% 32.62% -2.11%
============================================
Files 28 30 +2
Lines 4538 4861 +323
============================================
+ Hits 1576 1586 +10
- Misses 2787 3100 +313
Partials 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, NicholasYancey, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@NicholasYancey: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why the changes were made
OADP 1.6 added Console CLI download support in #1997: the operator deploys an oadp-cli download server and registers a ConsoleCLIDownload so users can install the CLI from Help → Command line tools in the OpenShift Console.
This PR backports the Console CLI download flow to oadp-1.4, with 1.4-specific adjustments:
RELATED_IMAGE_CONSOLE_CLI_DOWNLOADpoints atquay.io/konveyor/oadp-cli-binaries:oadp-1.4.internal/controller/package path (1.5/1.6) tocontrollers/for 1.4 compatibility.How to test the changes made
git checkout backport-cli-download-1.5 make testCovers unit tests: console_test.go, vet, lint, bundle generation, and go mod verify.