NO-JIRA: Handle wrapped ENOTSUP error

[rh-roman]

system.Lsetxattr wraps syscall errors in XattrError, so comparing the
result with == against syscall.ENOTSUP and ErrNotSupportedPlatform never
matched, causing layer extraction to fail on filesystems that do not
support xattrs instead of silently skipping them.

Replace both == comparisons with errors.Is.

Co-Authored-By: Claude Sonnet 4.6

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility when restoring archived files across platforms.
  • Unsupported extended-attribute operations are now handled reliably without interrupting extraction.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

createTarFile now uses wrapped-error matching when ignoring unsupported extended-attribute errors during archive creation.

Changes

Xattr error handling

Layer / File(s)	Summary
Use wrapped error matching pkg/cli/image/archive/archive.go	Adds the errors import and replaces direct comparisons with errors.Is checks for unsupported platform and ENOTSUP errors.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: rhamitarora, rhmdnd, ardaguclu, cfergeau, soltysh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

_{Comment @coderabbitai help to get the list of available commands.}

[rh-roman]

/retest

[ardaguclu]

Thank you
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, rh-roman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rh-roman]

/retest

[rh-roman]

/retest

[ardaguclu]

Failure is unrelated and supposed to be fixed by #2315
/override ci/prow/okd-scos-images

[openshift-ci]

@ardaguclu: Overrode contexts on behalf of ardaguclu: ci/prow/okd-scos-images

Details

In response to this:

Failure is unrelated and supposed to be fixed by #2315
/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@rh-roman: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rh-roman]

/verified by CI

[openshift-ci-robot]

@rh-roman: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rh-roman: This pull request explicitly references no jira issue.

Details

In response to this:

system.Lsetxattr wraps syscall errors in XattrError, so comparing the
result with == against syscall.ENOTSUP and ErrNotSupportedPlatform never
matched, causing layer extraction to fail on filesystems that do not
support xattrs instead of silently skipping them.

Replace both == comparisons with errors.Is.

Co-Authored-By: Claude Sonnet 4.6

Summary by CodeRabbit

• Bug Fixes
• Improved compatibility when restoring archived files across platforms.
• Unsupported extended-attribute operations are now handled reliably without interrupting extraction.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.