Skip to content

PSHP-386: Update spdystream#2312

Open
vincentdephily wants to merge 1 commit into
openshift:mainfrom
vincentdephily:vdp-update-spdystream
Open

PSHP-386: Update spdystream#2312
vincentdephily wants to merge 1 commit into
openshift:mainfrom
vincentdephily:vdp-update-spdystream

Conversation

@vincentdephily

@vincentdephily vincentdephily commented Jul 15, 2026

Copy link
Copy Markdown

Fixes CVE-2026-35469.

Summary by CodeRabbit

  • Chores
    • Updated an underlying networking dependency to a newer maintenance version for improved reliability and compatibility.

@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown

@vincentdephily: This pull request references PSHP-386 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Fixes CVE-2026-3549.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Walkthrough

The indirect github.com/moby/spdystream dependency is updated from v0.5.0 to v0.5.1 in go.mod.

Changes

Dependency Update

Layer / File(s) Summary
Update spdystream requirement
go.mod
Updates the indirect github.com/moby/spdystream module requirement to v0.5.1.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tchap, ardaguclu

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only bumps vendored spdystream dependencies and implementation code.
Test Structure And Quality ✅ Passed PR only bumps spdystream in go.mod/vendor; no Ginkgo test code was added or modified.
Microshift Test Compatibility ✅ Passed PASS: The PR only updates go.mod/vendor for spdystream; no *_test.go files or Ginkgo It/Describe/Context/When blocks were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only bumps vendored spdystream deps, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only bumps moby/spdystream in go.mod/vendor; no manifests, operator code, or scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed PR only bumps vendored spdystream/go.mod; no main/init/TestMain/Ginkgo setup or stdout writes were added in process-level code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only vendored spdystream/go.mod updates changed; no new Ginkgo/e2e tests or network-using test code were added.
No-Weak-Crypto ✅ Passed Changed files only bump spdystream vendor deps; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found in the diff.
Container-Privileges ✅ Passed The PR only bumps spdystream in go.mod/go.sum and vendor files; no container/K8s manifests or privilege settings were changed.
No-Sensitive-Data-In-Logs ✅ Passed PR only bumps spdystream and adds frame-validation; changed files contain no new logging or sensitive-data fields.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and clearly matches the spdystream dependency update in the PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from ardaguclu and tchap July 15, 2026 10:19

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 160: Update the remediation CVE mapping for the
github.com/moby/spdystream v0.5.1 dependency to use CVE-2026-35469 instead of
the truncated CVE-2026-3549 identifier.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0fb99183-7c13-4a37-9993-bb4dc4c8e9b2

📥 Commits

Reviewing files that changed from the base of the PR and between 0609001 and aa06805.

⛔ Files ignored due to path filters (11)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/moby/spdystream/NOTICE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/connection.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/PATENTS is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/dictionary.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/options.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/read.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/types.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/spdystream/spdy/write.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
@vincentdephily
vincentdephily force-pushed the vdp-update-spdystream branch from aa06805 to 1cc0a15 Compare July 15, 2026 10:34
@tchap

tchap commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agent-compact-ipv4

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap, vincentdephily
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincentdephily

Copy link
Copy Markdown
Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@vincentdephily: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 1cc0a15 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants