[OSDOCS#17057[: CQA 2.0 disconnected cluster - installing #116157
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||
| // Module included in the following assemblies: | ||||||
| // | ||||||
| // disconnected/installing.adoc | ||||||
|
|
||||||
| :_mod-docs-content-type: REFERENCE | ||||||
| ifndef::openshift-origin[] | ||||||
| [id="installing-agent_{context}"] | ||||||
| = Installing a cluster with the Agent-based Installer | ||||||
|
|
||||||
| [role="_abstract"] | ||||||
| You can install an {product-title} cluster in a disconnected environment with the Agent-based installer. | ||||||
|
Contributor
There was a problem hiding this comment. Nit - capital I:
Suggested change
|
||||||
|
|
||||||
| For more information, see: | ||||||
|
Contributor
There was a problem hiding this comment. This is good, I would add "the following" to more explicitly introduce the list with a full sentence (it's a style guide rule for translation)
Suggested change
Please apply this to your other modules as well |
||||||
|
|
||||||
| * xref:../installing/installing_with_agent_based_installer/understanding-disconnected-installation-mirroring.adoc#understanding-disconnected-installation-mirroring[Understanding disconnected installation mirroring] | ||||||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||||||
|
|
||||||
| * xref:../installing/installing_with_agent_based_installer/installing-with-agent-based-installer.adoc#installing-with-agent-based-installer[Installing an {product-title} cluster with the Agent-based Installer] | ||||||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules).
Contributor
There was a problem hiding this comment. This is not your fault but since this was first written I have changed the name of this assembly and forgot to update the xref here:
Suggested change
|
||||||
| endif::openshift-origin[] | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-aws_{context}"] | ||
| = Installing a cluster on {aws-full} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {aws-first} in a disconnected environment. | ||
|
|
||
| For more information, see: | ||
|
|
||
| * Installer-provisioned infrastructure: xref:../installing/installing_aws/ipi/installing-restricted-networks-aws-installer-provisioned.adoc#installing-restricted-networks-aws-installer-provisioned[Installing a cluster on {aws-short} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
|
|
||
| * User-provisioned infrastructure: xref:../installing/installing_aws/upi/installing-restricted-networks-aws.adoc#installing-restricted-networks-aws[Installing a cluster on {aws-short} in a restricted network with user-provisioned infrastructure] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-azure_{context}"] | ||
| = Installing a cluster on {azure-full} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {azure-first} in a disconnected environment. | ||
|
|
||
| For more information, see: | ||
|
|
||
| * Installer-provisioned infrastructure: xref:../installing/installing_azure/ipi/installing-restricted-networks-azure-installer-provisioned.adoc#installing-restricted-networks-azure-installer-provisioned[Installing a cluster on {azure-short} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
|
|
||
| * User-provisioned infrastructure: xref:../installing/installing_azure/upi/installing-restricted-networks-azure-user-provisioned.adoc#installing-restricted-networks-azure-user-provisioned[Installing a cluster on {azure-short} in a restricted network with user-provisioned infrastructure] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-baremetal_{context}"] | ||
| = Installing a bare metal cluster | ||
|
rh-sgehlot marked this conversation as resolved.
|
||
|
|
||
| [role="_abstract"] | ||
| You can install a bare metal {product-title} cluster in a disconnected environment. | ||
|
|
||
| For more information, see xref:../installing/installing_bare_metal/upi/installing-restricted-networks-bare-metal.adoc#installing-restricted-networks-bare-metal[Installing a user-provisioned bare metal cluster on a restricted network]. | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules).
rh-sgehlot marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-gcp_{context}"] | ||
| = Installing a cluster on {gcp-full} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {gcp-first} in a disconnected environment. | ||
|
|
||
| For more information, see: | ||
|
|
||
| * Installer-provisioned infrastructure: xref:../installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc#installing-restricted-networks-gcp-installer-provisioned[Installing a cluster on {gcp-short} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
|
|
||
| * User-provisioned infrastructure: xref:../installing/installing_gcp/installing-restricted-networks-gcp.adoc#installing-restricted-networks-gcp[Installing a cluster on {gcp-short} in a restricted network with user-provisioned infrastructure] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| ifndef::openshift-origin[] | ||
| [id="installing-ibm-cloud_{context}"] | ||
| = Installing a cluster on {ibm-cloud-title} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {ibm-cloud-name} in a disconnected environment. | ||
|
|
||
| For more information, see xref:../installing/installing_ibm_cloud/installing-ibm-cloud-restricted.adoc#installing-ibm-cloud-restricted[Installing a cluster on {ibm-cloud-title} in a restricted network]. | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
| endif::openshift-origin[] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| ifndef::openshift-origin[] | ||
| [id="installing-ibm-power_{context}"] | ||
| = Installing a cluster on {ibm-power-title} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {ibm-power-title} in a disconnected environment. | ||
|
|
||
| For more information, see xref:../installing/installing_ibm_power/installing-restricted-networks-ibm-power.adoc#installing-restricted-networks-ibm-power[Installing a cluster on {ibm-power-title} in a restricted network]. | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
| endif::openshift-origin[] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| ifndef::openshift-origin[] | ||
| [id="installing-ibm-z_{context}"] | ||
| = Installing a cluster on {ibm-z-name} or {ibm-linuxone-name} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {ibm-z-name} or {ibm-linuxone-name} in a disconnected environment. | ||
|
|
||
| For more information, see: | ||
|
|
||
| * xref:../installing/installing_ibm_z/upi/installing-restricted-networks-ibm-z.adoc#installing-restricted-networks-ibm-z[Installing a cluster with z/VM on {ibm-z-title} and {ibm-linuxone-title} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
|
|
||
| * xref:../installing/installing_ibm_z/upi/installing-restricted-networks-ibm-z-kvm.adoc#installing-restricted-networks-ibm-z-kvm[Installing a cluster with {op-system-base} KVM on {ibm-z-title} and {ibm-linuxone-title} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
|
|
||
| * xref:../installing/installing_ibm_z/upi/installing-restricted-networks-ibm-z-lpar.adoc#installing-restricted-networks-ibm-z-lpar[Installing a cluster in an LPAR on {ibm-z-title} and {ibm-linuxone-title} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
| endif::openshift-origin[] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-nutanix_{context}"] | ||
| = Installing a cluster on Nutanix | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on Nutanix in a disconnected environment. | ||
|
|
||
| For more information, see xref:../installing/installing_nutanix/installing-restricted-networks-nutanix-installer-provisioned.adoc#installing-restricted-networks-nutanix-installer-provisioned[Installing a cluster on Nutanix in a restricted network]. | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-ibm-openstack_{context}"] | ||
| = Installing a cluster on OpenStack | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {rh-openstack-first} in a disconnected environment. | ||
|
|
||
| For more information, see xref:../installing/installing_openstack/installing-openstack-installer-restricted.adoc#installing-openstack-installer-restricted[Installing a cluster on OpenStack in a restricted network]. | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // disconnected/installing.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installing-vsphere_{context}"] | ||
| = Installing a cluster on {vmw-short} | ||
|
|
||
| [role="_abstract"] | ||
| You can install an {product-title} cluster on {vmw-first} in a disconnected environment. | ||
|
|
||
| For more information, see: | ||
|
|
||
| * Installer-provisioned infrastructure: xref:../installing/installing_vsphere/ipi/installing-restricted-networks-installer-provisioned-vsphere.adoc#installing-restricted-networks-installer-provisioned-vsphere[Installing a cluster on {vmw-short} in a restricted network] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
|
|
||
| * User-provisioned infrastructure: xref:../installing/installing_vsphere/upi/installing-restricted-networks-vsphere.adoc#installing-restricted-networks-vsphere[Installing a cluster on {vmw-short} in a restricted network with user-provisioned infrastructure] | ||
|
Collaborator
There was a problem hiding this comment. 🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules). |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modularization looks good, but the ifndef needs to be put back to make sure that this content is excluded from openshift origin/OKD:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that you put the conditionals inside the module.
In this specific case, because everything inside the module is conditionalized anyways, what you should do instead is put the conditionals around the module include statement in the assembly, like the comment above.
Please also make the same feedback for all other modules with conditionals for the okd distro