[release-4.21] Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems#392
Conversation
Some virtual media slots on Cisco C845A M8 (and potentially other OpenBMC-based systems) only support local/KVM access via WebSocket/NBD and do not expose the InsertMedia Redfish action. Attempting to use these slots results in HTTP 405 (Method Not Allowed). This patch adds a pre-check to skip slots without the InsertMedia action, and catches HTTP 405 errors as a fallback to try the next available slot. Change-Id: I6242c62f691bf642708c9ab147522cee88edd3a7 Signed-off-by: Jacob Anders <jacob-anders-dev@proton.me> Assisted-By: Claude Code Opus 4.6 (cherry picked from commit 8c95a7b) (cherry picked from commit 3be7de98b1196ca0837f3ceca25c3ee60f5bfb94)
|
/test unit |
|
/retest |
|
/lgtm |
|
/test unit |
|
@jacob-anders: This pull request references Jira Issue OCPBUGS-82294, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iurygregory, jacob-anders The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jacob-anders: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jacob-anders: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jacob-anders: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
0ebaa7e
into
openshift:release-4.21
Some virtual media slots on Cisco C845A M8 (and potentially other OpenBMC-based systems) only support local/KVM access via WebSocket/NBD and do not expose the InsertMedia Redfish action. Attempting to use these slots results in HTTP 405 (Method Not Allowed).
This patch adds a pre-check to skip slots without the InsertMedia action, and catches HTTP 405 errors as a fallback to try the next available slot.
Change-Id: I6242c62f691bf642708c9ab147522cee88edd3a7
Assisted-By: Claude Code Opus 4.6
(cherry picked from commit 8c95a7b) (cherry picked from commit 3be7de98b1196ca0837f3ceca25c3ee60f5bfb94)