Skip to content

[release-4.20] Bug OCPBUGS-82295: Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems#393

Open
jacob-anders wants to merge 1 commit intoopenshift:release-4.20from
jacob-anders:977605-4.20-backport
Open

[release-4.20] Bug OCPBUGS-82295: Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems#393
jacob-anders wants to merge 1 commit intoopenshift:release-4.20from
jacob-anders:977605-4.20-backport

Conversation

@jacob-anders
Copy link
Copy Markdown

Some virtual media slots on Cisco C845A M8 (and potentially other OpenBMC-based systems) only support local/KVM access via WebSocket/NBD and do not expose the InsertMedia Redfish action. Attempting to use these slots results in HTTP 405 (Method Not Allowed).

This patch adds a pre-check to skip slots without the InsertMedia action, and catches HTTP 405 errors as a fallback to try the next available slot.

Change-Id: I6242c62f691bf642708c9ab147522cee88edd3a7

Assisted-By: Claude Code Opus 4.6
(cherry picked from commit 8c95a7b) (cherry picked from commit 3be7de98b1196ca0837f3ceca25c3ee60f5bfb94) (cherry picked from commit bf4ff2e)

Some virtual media slots on Cisco C845A M8 (and potentially other
OpenBMC-based systems) only support local/KVM access via WebSocket/NBD
and do not expose the InsertMedia Redfish action. Attempting to use
these slots results in HTTP 405 (Method Not Allowed).

This patch adds a pre-check to skip slots without the InsertMedia
action, and catches HTTP 405 errors as a fallback to try the next
available slot.

Change-Id: I6242c62f691bf642708c9ab147522cee88edd3a7
Signed-off-by: Jacob Anders <jacob-anders-dev@proton.me>
Assisted-By: Claude Code Opus 4.6
(cherry picked from commit 8c95a7b)
(cherry picked from commit 3be7de98b1196ca0837f3ceca25c3ee60f5bfb94)
(cherry picked from commit bf4ff2e)
@jacob-anders jacob-anders changed the title [release-4.20 Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems [release-4.20] Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems Apr 10, 2026
@openshift-ci openshift-ci bot requested review from dtantsur and zaneb April 10, 2026 05:08
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacob-anders
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacob-anders jacob-anders changed the title [release-4.20] Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems [release-4.20] Bug OCPBUGS-82295: Fix vMedia insertion on Cisco C845A M8 and similar OpenBMC systems Apr 10, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 10, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jacob-anders: This pull request references Jira Issue OCPBUGS-82295, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-82294 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Some virtual media slots on Cisco C845A M8 (and potentially other OpenBMC-based systems) only support local/KVM access via WebSocket/NBD and do not expose the InsertMedia Redfish action. Attempting to use these slots results in HTTP 405 (Method Not Allowed).

This patch adds a pre-check to skip slots without the InsertMedia action, and catches HTTP 405 errors as a fallback to try the next available slot.

Change-Id: I6242c62f691bf642708c9ab147522cee88edd3a7

Assisted-By: Claude Code Opus 4.6
(cherry picked from commit 8c95a7b) (cherry picked from commit 3be7de98b1196ca0837f3ceca25c3ee60f5bfb94) (cherry picked from commit bf4ff2e)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MahnoorAsghar
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@MahnoorAsghar
Copy link
Copy Markdown

#395 might help with the unit job

@MahnoorAsghar
Copy link
Copy Markdown

/test unit

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 10, 2026

@jacob-anders: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants