AGENT-1522: bump InternalReleaseImage to v1#31294
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request references AGENT-1522 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdates Go module versions, migrates InternalReleaseImage test helpers from MachineConfig v1alpha1 to stable v1, and adds a ConfigV1 shim accessor for CRIO credential provider configs. ChangesDependency and client updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 469: The go.mod currently replaces github.com/openshift/api with a
personal fork (github.com/pawanpinjarkar/api v0.0.0-...) — remove or justify
this replace entry: either revert the replace to a vetted upstream tagged
release or, if the fork is required, add a PR rationale and approval trail in
the PR description referencing the replace line and module name, document
whether this is temporary or permanent, and include provenance evidence
(SBOM/signing/cosign or sigstore attestations), license compatibility and
CVE/osv.dev checks for that specific pseudo-version, and a compatibility
statement confirming no API-breaking changes for
github.com/openshift/api/config/*; block production usage until these
checks/approvals are added or remove the replace and use an officially governed
source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1cf63daf-600b-42d4-bc1d-3ec6217ec934
⛔ Files ignored due to path filters (17)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/api/.ci-operator.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/Dockerfile.ocpis excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/config/v1alpha1/types_cluster_monitoring.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/config/v1alpha1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/github.com/openshift/api/config/v1alpha1/zz_generated.swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/github.com/openshift/api/features.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/features/features.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/register.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/types_internalreleaseimage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.featuregated-crd-manifests.yamlis excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/github.com/openshift/api/operator/v1/types_etcd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/api/operator/v1/zz_generated.swagger_doc_generated.gois excluded by!**/vendor/**,!vendor/**,!**/zz_generated*vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880 |
|
@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880 |
|
@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job-with-prs ? |
|
@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
test/extended/internalreleaseimage/helper.go (1)
51-55:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winIncomplete v1alpha1 to v1 migration in
test/extended/internalreleaseimage/helper.go. BothGetIRI()(Line 52) andDeleteIRI()(Line 88) still reference the removedh.McClientV1alpha1field instead ofh.McClientV1. The correct v1 migration pattern is shown on Line 244. These references will cause compilation errors.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/extended/internalreleaseimage/helper.go` around lines 51 - 55, GetIRI() and DeleteIRI() still use the removed h.McClientV1alpha1 client and will not compile; update both functions to use h.McClientV1 instead (i.e., replace references to h.McClientV1alpha1.InternalReleaseImages() with h.McClientV1.InternalReleaseImages()) and keep the existing calls to Get(context.Background(), IRIResourceName, metav1.GetOptions{}) and Delete(context.Background(), IRIResourceName, metav1.DeleteOptions{}) unchanged so they follow the v1 migration pattern used elsewhere (see the pattern around the other v1 usage).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@test/extended/internalreleaseimage/helper.go`:
- Around line 51-55: GetIRI() and DeleteIRI() still use the removed
h.McClientV1alpha1 client and will not compile; update both functions to use
h.McClientV1 instead (i.e., replace references to
h.McClientV1alpha1.InternalReleaseImages() with
h.McClientV1.InternalReleaseImages()) and keep the existing calls to
Get(context.Background(), IRIResourceName, metav1.GetOptions{}) and
Delete(context.Background(), IRIResourceName, metav1.DeleteOptions{}) unchanged
so they follow the v1 migration pattern used elsewhere (see the pattern around
the other v1 usage).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dad0f1c4-b0f9-4a6e-8d82-85157cc6056e
📒 Files selected for processing (1)
test/extended/internalreleaseimage/helper.go
openshift-ci
Bot
added
the
ready-for-human-review
00d544f to
4437a1b
Compare
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880 openshift/client-go#383 |
|
@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
4437a1b to
552a5e8
Compare
|
Scheduling required tests: |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview |
|
@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/test e2e-aws-ovn-fips |
|
/retest-required |
|
/test e2e-aws-ovn-fips |
openshift-ci
Bot
added
needs-rebase
|
/test ? |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
Scheduling required tests: |
|
/lgtm |
d2e8fa4 to
b1f40d1
Compare
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bfournie, pawanpinjarkar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
1 similar comment
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/verified by ci/prow/e2e-agent-compact-ipv4-iso-no-registry |
openshift-ci-robot
added
the
verified
|
@pawanpinjarkar: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
@pawanpinjarkar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary by CodeRabbit
Summary by CodeRabbit
Chores
Tests
Requires