OCPBUGS-98322: switch e2e-aws-upgrade to nested workflow on 4.23 and 5.0

[celebdor]

Summary

• Switch e2e-aws-upgrade periodic jobs on 4.23 and 5.0 from hypershift-aws-e2e-external to hypershift-aws-e2e-nested workflow
• Fixes immediate "unbound variable" crash (0% pass rate) caused by MGMT_PARENT_KUBECONFIG not being declared in the external workflow's env
• Aligns with main, which switched to nested in PR NO-JIRA: hypershift: slim down e2e footprint #76723 but did not propagate the change to release branch periodics

Root Cause

The e2e-aws-upgrade jobs set REQUEST_SERVING_COMPONENT_TEST=true, which causes the script to reference $MGMT_PARENT_KUBECONFIG. The external workflow never declared this env var or mounted the hypershift-ci-2 credential, so set -o nounset aborts immediately. The nested workflow has both configured correctly, and main already uses it.

Test plan

• e2e-aws-upgrade periodic jobs on 4.23 and 5.0 should stop crashing with "unbound variable"
• Upgrade tests with REQUEST_SERVING_COMPONENT_TEST=true should proceed past the variable expansion

Fixes: https://issues.redhat.com/browse/OCPBUGS-98322

🤖 Generated with Claude Code

Summary by CodeRabbit

Updates the HyperShift AWS upgrade periodic jobs for release 4.23 and 5.0 to use the hypershift-aws-e2e-nested workflow instead of the external workflow. This avoids the external workflow’s missing environment variable and credential mount, preventing unbound variable failures when running component tests.

[openshift-ci-robot]

@celebdor: This pull request references Jira Issue OCPBUGS-98322, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Add MGMT_PARENT_KUBECONFIG env var and hypershift-ci-2 credential mount to hypershift-aws-run-e2e-external-ref.yaml
• Fixes immediate "unbound variable" crash in e2e-aws-upgrade periodic jobs (0% pass rate on 4.23 and 5.0)
• Aligns the external variant with the nested variant which already has both configured correctly

Root Cause

The script uses set -o nounset and references $MGMT_PARENT_KUBECONFIG when REQUEST_SERVING_COMPONENT_TEST=true, but the external ref YAML never declared the variable or mounted the credential containing the kubeconfig file.

Test plan

• e2e-aws-upgrade periodic jobs on 4.23 and 5.0 should stop crashing with "unbound variable"
• Upgrade tests with REQUEST_SERVING_COMPONENT_TEST=true should proceed past the variable expansion

Fixes: https://issues.redhat.com/browse/OCPBUGS-98322

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The scheduled e2e-aws-upgrade jobs for Hypershift releases 4.23 and 5.0 now use hypershift-aws-e2e-nested instead of hypershift-aws-e2e-external.

Changes

Hypershift upgrade workflow routing

Layer / File(s)	Summary
Update AWS upgrade job workflows ci-operator/config/openshift/hypershift/*__periodics.yaml	The e2e-aws-upgrade jobs for releases 4.23 and 5.0 now reference the nested AWS workflow.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: lgtm, rehearsals-ack

Suggested reviewers: danilo-gemoli, deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR only changes ci-operator periodic YAML workflow references; no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	Only two CI periodic YAMLs changed; no Ginkgo test code was modified, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	Only periodic job workflow references changed; no new Ginkgo tests or test bodies were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	HEAD only changes two periodic YAML configs; no Go/Ginkgo test files or new specs were added, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI periodic workflow refs changed; no deployment manifests, operators, or topology-sensitive scheduling logic were added.
Ote Binary Stdout Contract	✅ Passed	PASS: Diff only updates periodic workflow references in YAML; no OTE binary/process-level code, stdout logging, or suite setup changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Diff only swaps periodic job workflows in YAML; no new Ginkgo tests or network/IP logic were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	The commit only switches two periodic jobs from external to nested workflows; no crypto primitives, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	Diff only swaps periodic workflow refs from external to nested in two YAMLs; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only switches two periodic YAML workflow refs; no logging statements or secret-bearing fields were added in the touched files.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main change: switching the e2e-aws-upgrade periodic jobs on 4.23 and 5.0 to the nested workflow.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[celebdor]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-upgrade

[openshift-merge-bot]

@celebdor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jparrill]

/approve

[jparrill]

/lgtm

[celebdor]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-upgrade

[jparrill]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

@celebdor: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@celebdor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-upgrade	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-upgrade	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[celebdor]

/jira refresh

[openshift-ci-robot]

@celebdor: This pull request references Jira Issue OCPBUGS-98322, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[celebdor]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-upgrade

[openshift-merge-bot]

@celebdor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@celebdor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.