DRAFT DO NOT MERGE - [MCO][5.0][CONFIG][METAL] added extra disks and workers by proietfb · Pull Request #81733 · openshift/release

proietfb · 2026-07-10T10:37:33Z

Added DEVSCRIPTS_CONFIG variables to machine-config-operator e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview 5.0 job in order to have additional disks and workers.

This change is a draft to check the compatibility for bare metal tests on MCO-PR#6085

Summary by CodeRabbit

Updates the OpenShift CI Machine Config Operator 5.0 bare-metal disruptive TechPreview job e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview to provision additional test resources. The job now documents that it uses “extra disks” and extends DEVSCRIPTS_CONFIG to enable extra disks (VM_EXTRADISKS=true) with devices vda vdb, allocating 16G each, and adds NUM_EXTRA_WORKERS=1 to increase worker capacity for compatibility testing with upcoming MCO changes. Only this job definition is modified.

coderabbitai · 2026-07-10T10:38:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8953dbe9-4006-4afc-8b75-4ecfd8d830f0

📥 Commits

Reviewing files that changed from the base of the PR and between 01f1cf3 and 2bca3e2.

📒 Files selected for processing (1)

ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml

Walkthrough

The disruptive TechPreview periodic job now documents and enables two 16G extra disks and one additional worker through DEVSCRIPTS_CONFIG.

Changes

MCO periodic job configuration

Layer / File(s)	Summary
Configure extra disks and worker `ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml`	The `e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview` job documents its extra-disk setup, enables disks `vda vdb` at `16G`, and adds one extra worker.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: cheesesashimi, umohnani8

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change by mentioning extra disks and workers for the MCO config.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only edits a ci-operator job config doc/env block; no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	Only a ci-operator periodic YAML changed; no Ginkgo test code was added or modified, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	PR only edits a periodic job YAML; no Ginkgo tests or MicroShift-incompatible APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a ci-operator periodic job config changed; no new Ginkgo tests or SNO-relevant test logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only updates a ci-operator periodic job's DEVSCRIPTS_CONFIG for extra disks/workers; no deployment manifests, replicas, affinity, or node selectors were changed.
Ote Binary Stdout Contract	✅ Passed	Only a ci-operator YAML job config changed; no process-level code or stdout/logging paths were modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only CI job config changed; no new Ginkgo tests or network code were added, so the IPv4/disconnected check is not applicable.
No-Weak-Crypto	✅ Passed	The change only adds dev-scripts disk/worker settings in a YAML job stanza; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto is present.
Container-Privileges	✅ Passed	The PR only adds DEVSCRIPTS_CONFIG env vars; no privileged, host* or allowPrivilegeEscalation settings appear in the changed job or referenced workflow.
No-Sensitive-Data-In-Logs	✅ Passed	No new logging of secrets/PII; the change only adds DEVSCRIPTS_CONFIG vars and a doc note, with no passwords, tokens, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

⚔️ Resolve merge conflicts

Resolve merge conflict in branch IC_bare_metal_changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

proietfb · 2026-07-10T10:48:30Z

/pj-rehearse e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview

openshift-merge-bot · 2026-07-10T10:48:33Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-10T10:51:45Z

@proietfb: job(s): e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview either don't exist or were not found to be affected, and cannot be rehearsed

proietfb · 2026-07-10T10:54:52Z

/pj-rehearse

openshift-merge-bot · 2026-07-10T10:56:06Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-10T10:59:37Z

@proietfb: no rehearsable tests are affected by this change

openshift-merge-bot · 2026-07-10T11:06:46Z

@proietfb, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 6c828ffbaf5b86aaca3e14384fa6734a6ae0f469 due to conflicts

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

proietfb · 2026-07-10T11:22:11Z

/pj-rehearse

openshift-merge-bot · 2026-07-10T11:22:14Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-10T11:22:15Z

@proietfb, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 6c828ffbaf5b86aaca3e14384fa6734a6ae0f469 due to conflicts

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-merge-bot · 2026-07-10T11:24:30Z

@proietfb, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto 6c828ffbaf5b86aaca3e14384fa6734a6ae0f469 due to conflicts

openshift-merge-bot · 2026-07-10T12:17:49Z

@proietfb, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 65b0d4b8baf319aefcdf93d8a47954afd6496664 due to conflicts

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

proietfb · 2026-07-10T13:05:11Z

/pj-rehearse

openshift-merge-bot · 2026-07-10T13:05:13Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-10T13:05:31Z

@proietfb, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto c266a7355fa3a64459c2e9fa4d4ad37de324dbe0 due to conflicts

proietfb · 2026-07-10T13:33:12Z

/pj-rehearse

openshift-merge-bot · 2026-07-10T13:33:40Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-10T13:37:00Z

@proietfb: no rehearsable tests are affected by this change

proietfb · 2026-07-10T13:43:50Z

/hold

proietfb · 2026-07-10T13:48:53Z

/pj-rehearse e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview

openshift-ci · 2026-07-10T13:49:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: proietfb
Once this PR has been reviewed and has the lgtm label, please assign mahnoorasghar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/machine-config-operator/OWNERS~~ [proietfb]
ci-operator/step-registry/baremetalds/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-07-10T13:50:12Z

[REHEARSALNOTIFIER]
@proietfb: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-capi-operator-main-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-5.1-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-5.0-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.23-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.22-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.21-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.20-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.19-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.18-e2e-metal3-capi-techpreview	openshift/cluster-capi-operator	presubmit	Registry content changed
pull-ci-openshift-router-master-e2e-metal-ipi-ovn-ipv6	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-master-e2e-metal-ipi-ovn-dualstack	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-master-e2e-metal-ipi-ovn-router	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-5.1-e2e-metal-ipi-ovn-ipv6	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-5.1-e2e-metal-ipi-ovn-dualstack	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-5.1-e2e-metal-ipi-ovn-router	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-5.0-e2e-metal-ipi-ovn-ipv6	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-5.0-e2e-metal-ipi-ovn-dualstack	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-5.0-e2e-metal-ipi-ovn-router	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.23-e2e-metal-ipi-ovn-ipv6	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.23-e2e-metal-ipi-ovn-dualstack	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.23-e2e-metal-ipi-ovn-router	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.22-e2e-metal-ipi-ovn-ipv6	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.22-e2e-metal-ipi-ovn-dualstack	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.22-e2e-metal-ipi-ovn-router	openshift/router	presubmit	Registry content changed
pull-ci-openshift-router-release-4.21-e2e-metal-ipi-ovn-ipv6	openshift/router	presubmit	Registry content changed

A total of 2778 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-merge-bot · 2026-07-10T13:50:13Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-10T13:53:22Z

@proietfb: job(s): e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview either don't exist or were not found to be affected, and cannot be rehearsed

proietfb · 2026-07-10T14:19:06Z

/pj-rehearse periodic-ci-openshift-machine-config-operator-release-5.0-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview-1of3

openshift-merge-bot · 2026-07-10T14:19:09Z

@proietfb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-07-10T17:02:34Z

@proietfb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-machine-config-operator-release-5.0-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview-1of3	`1e13c13`	link	unknown	`/pj-rehearse periodic-ci-openshift-machine-config-operator-release-5.0-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview-1of3`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from cheesesashimi and yuqi-zhang July 10, 2026 10:38

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 10, 2026

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026

proietfb added 3 commits July 10, 2026 15:26

[MCO][5.0][CONFIG][METAL] added extra disks and workers

ebcb5cc

Added documentation field

a07f2ce

sanitized

412e3fc

proietfb force-pushed the IC_bare_metal_changes branch from 87a1a1a to 412e3fc Compare July 10, 2026 13:30

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2026

WIP: add blocking loop for bare metal irreconcilable changes testing

1e13c13

openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026

openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 10, 2026

Uh oh!

Conversation

proietfb commented Jul 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-ci Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

proietfb commented Jul 10, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 10, 2026

Uh oh!

openshift-ci Bot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

proietfb commented Jul 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading