NO-JIRA: sippy: adapt to generic verify presubmit

[smg247]

Repurpose the verify-migrations job to run the broader make verify target and always run on PRs instead of only on migration changes. This is okay, as verify-migrations is cheap. It makes more sense to include the apm verification along with it in the same job and run on all PRs to ensure we are always up-to-date.

Summary by CodeRabbit

• Renames the verify-migrations presubmit job to verify and runs the broader HOME=/tmp make verify target.
• Applies verification, including APM checks, to every pull request instead of only migration-related changes.

[openshift-ci-robot]

@smg247: This pull request explicitly references no jira issue.

Details

In response to this:

Repurpose the verify-migrations job to run the broader make verify target and always run on PRs instead of only on migration changes. This is okay, as verify-migrations is cheap. It makes more sense to include the apm verification along with it in the same job and run on all PRs to ensure we are always up-to-date.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The Sippy CI configuration replaces the migrations-only verification step with a broader make verify step running in the src container without a change-path restriction.

Changes

Sippy CI verification

Layer / File(s)	Summary
Replace migration verification step ci-operator/config/openshift/sippy/openshift-sippy-main.yaml	The CI test now runs HOME=/tmp make verify in the src container instead of make verify-migrations restricted to migration changes.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

• openshift/release#81301: Introduced the migration-scoped verification step that this change replaces.

Suggested reviewers: deads2k

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@smg247: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-sippy-main-verify	openshift/sippy	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[smg247]

/pj-rehearse pull-ci-openshift-sippy-main-verify

[openshift-merge-bot]

@smg247: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@smg247: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/sippy/main/verify	c15bf48	link	unknown	/pj-rehearse pull-ci-openshift-sippy-main-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mstaeble]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstaeble, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/sippy/OWNERS [smg247]
• ci-operator/jobs/openshift/sippy/OWNERS [smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment