chore: add dynamic-scoring-framework repo#81752
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (11)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds repository ownership and Prow settings, plus CI Operator build and SonarCloud configurations for the main and release-5.1 branches. ChangesDynamic Scoring Framework CI Onboarding
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
dynamic-scoring-framework
branch
from
ea2d40b to
96ece98
Compare
|
@dhaiducek, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-release-5.1.yaml`:
- Around line 25-41: Update the sonarcloud and sonarcloud-postsubmit commands
blocks to export SELF, SONAR_ORG, and HOME="/tmp" before invoking the make
command, matching the corresponding main configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 22192a7b-8bd7-45a4-a7c7-5c123346a63d
⛔ Files ignored due to path filters (4)
ci-operator/jobs/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-release-5.1-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (6)
ci-operator/config/stolostron/dynamic-scoring-framework/OWNERSci-operator/config/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-main.yamlci-operator/config/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-release-5.1.yamlcore-services/prow/02_config/stolostron/dynamic-scoring-framework/OWNERScore-services/prow/02_config/stolostron/dynamic-scoring-framework/_pluginconfig.yamlcore-services/prow/02_config/stolostron/dynamic-scoring-framework/_prowconfig.yaml
| - as: sonarcloud | ||
| commands: | | ||
| make -f /opt/build-harness/Makefile.prow sonar/go/prow | ||
| container: | ||
| from: src | ||
| secrets: | ||
| - mount_path: /etc/sonarcloud/ | ||
| name: acm-sonarcloud-token | ||
| - as: sonarcloud-postsubmit | ||
| commands: | | ||
| make -f /opt/build-harness/Makefile.prow sonar/go/prow | ||
| container: | ||
| from: src | ||
| postsubmit: true | ||
| secrets: | ||
| - mount_path: /etc/sonarcloud/ | ||
| name: acm-sonarcloud-token |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major
SonarCloud commands missing required environment variable exports.
Same issue as flagged in the main config — the commands blocks for both sonarcloud and sonarcloud-postsubmit are missing export SELF, export SONAR_ORG, and export HOME="/tmp". Please apply the same fix here.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/stolostron/dynamic-scoring-framework/stolostron-dynamic-scoring-framework-release-5.1.yaml`
around lines 25 - 41, Update the sonarcloud and sonarcloud-postsubmit commands
blocks to export SELF, SONAR_ORG, and HOME="/tmp" before invoking the make
command, matching the corresponding main configuration.
|
@dhaiducek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
Adds OpenShift CI and Prow configuration for the
stolostron/dynamic-scoring-frameworkrepository, including:mainandrelease-5.1.