Skip to content

TRT-2689: add python 3.12 to bin-uv in order to actually utilize apm-cli#81758

Open
smg247 wants to merge 1 commit into
openshift:mainfrom
smg247:origin-bin-uv-python
Open

TRT-2689: add python 3.12 to bin-uv in order to actually utilize apm-cli#81758
smg247 wants to merge 1 commit into
openshift:mainfrom
smg247:origin-bin-uv-python

Conversation

@smg247

@smg247 smg247 commented Jul 10, 2026

Copy link
Copy Markdown
Member

The build root ships Python 3.9 which doesn't meet apm-cli's >=3.10 requirement, causing verify-apm to fail.

Summary by CodeRabbit

  • Updates the OpenShift origin bin-uv CI image setup to install Python 3.12, enabling apm-cli and preventing verify-apm failures caused by the existing Python 3.9 environment.

The build root ships Python 3.9 which doesn't meet apm-cli's >=3.10
requirement, causing verify-apm to fail.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@smg247: This pull request references TRT-2689 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The build root ships Python 3.9 which doesn't meet apm-cli's >=3.10 requirement, causing verify-apm to fail.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from deads2k and sjenning July 10, 2026 18:10
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4c6ee09c-77be-4a1a-a4c7-a1123f0931db

📥 Commits

Reviewing files that changed from the base of the PR and between b7b2f4e and 4afe2b6.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml

Walkthrough

The OpenShift origin CI pipeline now installs Python 3.12 through DNF and cleans DNF metadata afterward.

Changes

Origin CI environment

Layer / File(s) Summary
Python 3.12 installation
ci-operator/config/openshift/origin/openshift-origin-main.yaml
The raw CI steps install python3.12 with DNF and run dnf clean all.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding Python 3.12 to the bin-uv CI setup to support apm-cli.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a ci-operator YAML changed; no Ginkgo test titles or test files were modified, so the check is not applicable.
Test Structure And Quality ✅ Passed Only a CI config YAML changed; no Ginkgo test code or test assertions were modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only a CI config line changed to install Python 3.12; no new Ginkgo tests, APIs, or MicroShift-sensitive resources were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a ci-operator YAML line was added to install python3.12; no Ginkgo tests or SNO-relevant code changed.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR only adds dnf install -y python3.12 to a CI raw_steps command in ci-operator config; no deployment manifests, controllers, or scheduling constraints changed.
Ote Binary Stdout Contract ✅ Passed Only a CI YAML step changed; no process-level Go/Ginkgo code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a CI config step was changed; no new Ginkgo e2e tests or network-dependent test code were added.
No-Weak-Crypto ✅ Passed The only code change adds dnf install -y python3.12 && dnf clean all; no weak-crypto primitives or custom crypto were introduced.
Container-Privileges ✅ Passed Diff only adds a dnf install step in ci-operator config; no privileged, hostPID/hostNetwork/hostIPC, allowPrivilegeEscalation, or SYS_ADMIN settings appear.
No-Sensitive-Data-In-Logs ✅ Passed The patch only adds a dnf install step; no new logging, secret handling, or sensitive-data patterns were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@smg247: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-csi openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-disruptive openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-etcd-certrotation openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-etcd-recovery openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-jenkins openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-cgroupsv2 openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-dra-example openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-fips openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-image-registry openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-kube-apiserver-rollout openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-kubevirt openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-fast openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-ipsec openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-publicnet-1of2 openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-publicnet-2of2 openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial openshift/origin presubmit Ci-operator config changed

A total of 93 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smg247

smg247 commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-origin-main-verify

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smg247: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@smg247: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants