Skip to content

no-jira: remove the ossm pre-release job#81764

Open
rhamini3 wants to merge 1 commit into
openshift:mainfrom
rhamini3:remove-ossmjob
Open

no-jira: remove the ossm pre-release job#81764
rhamini3 wants to merge 1 commit into
openshift:mainfrom
rhamini3:remove-ossmjob

Conversation

@rhamini3

@rhamini3 rhamini3 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

With the addition of the NO-OLM GatewayAPI backport, the job no longer can run successfully

Summary by CodeRabbit

  • Disables automatic execution of the e2e-aws-pre-release-ossm OpenShift cluster ingress operator pre-release test, preventing the incompatible OSSM job from running after the NO-OLM GatewayAPI backport.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhamini3: This pull request explicitly references no jira issue.

Details

In response to this:

With the addition of the NO-OLM GatewayAPI backport, the job no longer can run successfully

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c6ead0c2-7b99-4013-95c2-5af3b55f61a1

📥 Commits

Reviewing files that changed from the base of the PR and between b6aaa20 and 7c3c6f3.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-release-4.21.yaml

Walkthrough

The OpenShift cluster ingress operator release workflow now explicitly sets always_run: false for the e2e-aws-pre-release-ossm test entry.

Changes

Ingress operator release workflow

Layer / File(s) Summary
Disable always-run for OSSM pre-release test
ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-release-4.21.yaml
Adds always_run: false to the e2e-aws-pre-release-ossm test configuration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: mdbooth, damdo, danilo-gemoli, deepsm007

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the stated intent to remove the OSSM pre-release job and is directly related to the config change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes a CI YAML job flag; no Ginkgo test titles or code-defined specs were added or modified.
Test Structure And Quality ✅ Passed PR only changes a CI YAML job entry; no Ginkgo test code or test patterns are touched, so the check is not applicable.
Microshift Test Compatibility ✅ Passed Only CI YAML changed; no new Ginkgo tests or test bodies were added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only changes CI job metadata (always_run on an existing job); it adds no new Ginkgo tests or SNO-sensitive logic.
Topology-Aware Scheduling Compatibility ✅ Passed PR only edits a ci-operator test entry; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only changes a CI YAML job entry; no OTE binary or process-level stdout code was touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR only changes CI job metadata (adds always_run:false); no new Ginkgo tests or network-dependent code was introduced.
No-Weak-Crypto ✅ Passed Only a CI YAML flag change was made; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the modified job.
Container-Privileges ✅ Passed The PR only adds always_run: false to an existing test stanza; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only toggles CI job metadata; the OSSM step reads secrets into env vars but does not log or echo them.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhamini3
Once this PR has been reviewed and has the lgtm label, please assign jcmoraisjr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from alebedev87 and gcs278 July 10, 2026 20:43
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rhamini3: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-aws-pre-release-ossm openshift/cluster-ingress-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@rhamini3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants