Skip to content

Hive: Bump to golang 1.26#81765

Open
2uasimojo wants to merge 1 commit into
openshift:mainfrom
2uasimojo:hive-golang-1.26
Open

Hive: Bump to golang 1.26#81765
2uasimojo wants to merge 1 commit into
openshift:mainfrom
2uasimojo:hive-golang-1.26

Conversation

@2uasimojo

@2uasimojo 2uasimojo commented Jul 10, 2026

Copy link
Copy Markdown
Member

Needed for openshift/hive#2925

Summary by CodeRabbit

  • Updates Hive’s CI build root images to use Go 1.26, enabling builds with the rhel-9-release-golang-1.26-openshift-4.23 release image for both master and periodic workflows.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6f79d0f3-2b48-4134-83df-44ffccb2a9f2

📥 Commits

Reviewing files that changed from the base of the PR and between b6aaa20 and e74dbdb.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/hive/openshift-hive-master.yaml
  • ci-operator/config/openshift/hive/openshift-hive-master__periodic.yaml

Walkthrough

Updates the Hive master and periodic CI build root configurations to reference the rhel-9-release-golang-1.26-openshift-4.23 image stream tag.

Changes

Hive build root configuration

Layer / File(s) Summary
Update release image stream tags
ci-operator/config/openshift/hive/*
Both master and periodic Hive configurations now use the Go 1.26, OpenShift 4.23 release image stream tag for builds.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested labels: lgtm, approved

Suggested reviewers: kaovilai, shubham-pampattiwar, Joeavaikath

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: Hive is bumped to Go 1.26.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only CI config YAML image tags changed; no Ginkgo test titles were added or modified, so the naming rule is not applicable.
Test Structure And Quality ✅ Passed PR only updates ci-operator YAML build-root tags; no Ginkgo test code or It blocks were changed, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: PR only updates ci-operator YAML build_root image tags; no new Go/Ginkgo tests or MicroShift-relevant APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator image tags changed; no Ginkgo tests were added or modified, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates ci-operator build_root image stream tags; no scheduling manifests, affinity, nodeSelector, tolerations, or replica logic changed.
Ote Binary Stdout Contract ✅ Passed Only ci-operator build-root image tags changed; no main/init/suite code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI config build_root image tags changed; no new Ginkgo tests, networking code, or external connectivity added.
No-Weak-Crypto ✅ Passed Only CI image tag values changed in YAML; no weak ciphers, custom crypto, or secret-comparison code appears in the touched files.
Container-Privileges ✅ Passed Only build_root release tags changed in the two YAML files; no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or root-security settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Only CI build_root image tags changed; no logging, secrets, or PII were added in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from dlom and jstuever July 10, 2026 21:44
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@2uasimojo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hive-master-coverage openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-e2e openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-e2e-azure openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-e2e-gcp openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-e2e-openstack openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-e2e-pool openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-e2e-vsphere openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-images openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-periodic-images openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-security openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-unit openshift/hive presubmit Ci-operator config changed
pull-ci-openshift-hive-master-verify openshift/hive presubmit Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-pool-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-vsphere-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-azure-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-gcp-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-openstack-weekly N/A periodic Ci-operator config changed
periodic-ci-openshift-hive-master-periodic-e2e-ote-sd-rosa N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@2uasimojo

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hive-master-images

...should be sufficient to determine that this works.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@2uasimojo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@2uasimojo

Copy link
Copy Markdown
Member Author

/retest-required

1 similar comment
@2uasimojo

Copy link
Copy Markdown
Member Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant