Skip to content

MGMT-24835: configuring the auto mode for assisted-test-infra#82090

Draft
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-test-infra
Draft

MGMT-24835: configuring the auto mode for assisted-test-infra#82090
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-test-infra

Conversation

@andrej1991

@andrej1991 andrej1991 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Summary by CodeRabbit

  • Enables auto mode for assisted-test-infra, allowing inexpensive checks to run first and required jobs to start after they pass.
  • Updates assisted-test-infra test pipelines across master and OCM 2.11–2.17 to use pipeline-specific change filters and explicitly disable unconditional execution.
  • Marks selected virtualization, OpenShift AI, and VLAN end-to-end jobs as optional.
  • Jira issue MGMT-24835 is valid; its missing target version still needs to be set to 5.0.0.

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@andrej1991: This pull request references MGMT-24835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrej1991
Once this PR has been reviewed and has the lgtm label, please assign danilo-gemoli, rccrdpccl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 13225cb0-1972-41cc-95f7-c3492a07254f

📥 Commits

Reviewing files that changed from the base of the PR and between 3f5f152 and bd18679.

⛔ Files ignored due to path filters (8)
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.11-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.12-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.13-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.14-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.15-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.16-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.17-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (9)
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.11.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.12.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.13.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.14.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.15.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.16.yaml
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.17.yaml
  • core-services/pipeline-controller/config.yaml

Walkthrough

Assisted test infrastructure was registered for automatic pipeline triggering. Master and release CI job definitions now use pipeline-specific change filters, explicitly set always_run: false, and mark three master jobs as optional.

Changes

Assisted test pipeline updates

Layer / File(s) Summary
Pipeline controller registration
core-services/pipeline-controller/config.yaml
Adds the assisted-test-infra organization with automatic trigger mode.
Master job trigger and optionality policies
ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
Renames change-filter keys to pipeline-specific variants, adds always_run: false to affected jobs, and marks three jobs optional.
Release job trigger policies
ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-release-ocm-2.*.yaml
Updates release HA kube-api jobs to use pipeline_skip_if_only_changed, adding always_run: false where specified while preserving existing patterns and metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: gmfrasca

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: enabling auto mode for assisted-test-infra.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Diff only touches ci-operator/pipeline YAML; no .go files or added/removed Ginkgo titles or dynamic title patterns were present.
Test Structure And Quality ✅ Passed No Ginkgo test files changed; the PR only updates CI/pipeline YAML, so this test-structure checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only CI/YAML job config changed; no Go/Ginkgo test sources or new It/Describe/Context/When blocks were added, so MicroShift compatibility is unchanged.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates CI YAML/pipeline config; no Go/Ginkgo test definitions were added or changed, so there are no new SNO assumptions to review.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI/pipeline config changed; no deployment manifests, operator code, or scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed Only CI YAML/pipeline config changed; no Go/binary entrypoints or stdout-producing process code were touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI/job YAML files changed; no Go/Ginkgo test code was added or modified, so the IPv4/external-connectivity check is not applicable.
No-Weak-Crypto ✅ Passed The PR only changes CI/pipeline YAML; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparisons appear in the diff.
Container-Privileges ✅ Passed The PR only changes CI/job and pipeline config; no added privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were found.
No-Sensitive-Data-In-Logs ✅ Passed Changed files are CI YAML configs only; scans found no log statements or sensitive strings (passwords, tokens, PII, keys).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants